Skip to content

Fix reading from compact parts with concurrent RENAMEs#75693

Merged
CurtizJ merged 5 commits intoClickHouse:masterfrom
CurtizJ:fix-concurrent-renames-alters
Feb 10, 2025
Merged

Fix reading from compact parts with concurrent RENAMEs#75693
CurtizJ merged 5 commits intoClickHouse:masterfrom
CurtizJ:fix-concurrent-renames-alters

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Feb 7, 2025 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed rare crashes while reading from MergeTree table after multiple asynchronous RENAME queries (with alter_sync = 0) between columns with different types.

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory and will run independently of the checks below:

  • Only: Stateless tests
  • Only: Integration tests
  • Only: Performance tests
  • Skip: Style check
  • Skip: Fast test
  • Run all checks ignoring all possible failures (Resource-intensive. All test jobs execute in parallel).
  • Disable CI cache

@robot-clickhouse robot-clickhouse added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Feb 7, 2025
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Feb 7, 2025 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 937b1bf with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here❌ failure
Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@kssenii kssenii self-assigned this Feb 7, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 7, 2025 •
edited
Loading

Workflow [PR], commit [6e68244]

kssenii
kssenii approved these changes Feb 10, 2025
View reviewed changes
CurtizJ and others added 2 commits February 10, 2025 14:53
@CurtizJ @kssenii
Update src/Storages/MergeTree/MergeTreeReaderCompact.cpp
469d77f 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
@CurtizJ
fix test
6e68244
@CurtizJ CurtizJ added this pull request to the merge queue Feb 10, 2025
Merged via the queue into ClickHouse:master with commit 9584bb3 Feb 10, 2025
116 checks passed
@CurtizJ CurtizJ deleted the fix-concurrent-renames-alters branch February 10, 2025 23:53
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 10, 2025
This was referenced Feb 11, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll3
Merge pull request #75889 from ClickHouse/cherrypick/24.8/75693
fcb5fe9 
Cherry pick #75693 to 24.8: Fix reading from compact parts with concurrent `RENAME`s
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #75693 to 24.8: Fix reading from compact parts with concurre…
31694df 
…nt `RENAME`s
This was referenced Feb 11, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll3
Merge pull request #75891 from ClickHouse/cherrypick/24.11/75693
859b83b 
Cherry pick #75693 to 24.11: Fix reading from compact parts with concurrent `RENAME`s
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #75693 to 24.11: Fix reading from compact parts with concurr…
45ad8af 
…ent `RENAME`s
This was referenced Feb 11, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll3
Merge pull request #75893 from ClickHouse/cherrypick/24.12/75693
61b1478 
Cherry pick #75693 to 24.12: Fix reading from compact parts with concurrent `RENAME`s
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #75693 to 24.12: Fix reading from compact parts with concurr…
f490e66 
…ent `RENAME`s
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 11, 2025
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 11, 2025
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll3
Merge pull request #75895 from ClickHouse/cherrypick/25.1/75693
743a821 
Cherry pick #75693 to 25.1: Fix reading from compact parts with concurrent `RENAME`s
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #75693 to 25.1: Fix reading from compact parts with concurre…
2674b67 
…nt `RENAME`s
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 11, 2025
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Feb 11, 2025
robot-clickhouse-ci-1 added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse-ci-1
Merge pull request #75892 from ClickHouse/backport/24.11/75693
2bbb6a6 
Backport #75693 to 24.11: Fix reading from compact parts with concurrent `RENAME`s
kssenii added a commit that referenced this pull request Feb 11, 2025
@kssenii
Merge pull request #75896 from ClickHouse/backport/25.1/75693
b6f9fb1 
Backport #75693 to 25.1: Fix reading from compact parts with concurrent `RENAME`s
kssenii added a commit that referenced this pull request Feb 11, 2025
@kssenii
Merge pull request #75894 from ClickHouse/backport/24.12/75693
5ffd9f5 
Backport #75693 to 24.12: Fix reading from compact parts with concurrent `RENAME`s
kssenii added a commit that referenced this pull request Feb 11, 2025
@kssenii
Merge pull request #75890 from ClickHouse/backport/24.8/75693
4ce37c1 
Backport #75693 to 24.8: Fix reading from compact parts with concurrent `RENAME`s
@Algunenano Algunenano mentioned this pull request Feb 12, 2025
Closed
@CurtizJ CurtizJ mentioned this pull request Feb 18, 2025
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 19, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@CurtizJ @robot-clickhouse @kssenii @robot-ch-test-poll @robot-ch-test-poll3 @robot-clickhouse-ci-2 @maxknv