Skip to content

Make MergerMutator more customizable #73294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Michicosun merged 96 commits into from
Jan 13, 2025
Merged

Make MergerMutator more customizable #73294

Michicosun merged 96 commits into from
Jan 13, 2025

Conversation

@Michicosun
Copy link
Member

@Michicosun Michicosun commented Dec 13, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@Michicosun
make some code stricter
b6c9647
@Michicosun
move files
72f12ca
@Michicosun
move part properties from merge selectors
da37644
@Michicosun
add more strict checks for ttl merge selectors
7f67605
@Michicosun
add visibile parts collector
1dce567
@Michicosun
add combinator
01bd4bf
@Michicosun
mv PartitionIdToTTLs to public
3416865
@Michicosun
rename interface file
415cbef
@Michicosun
add applier
37b5ff3
@Michicosun
add statistics
6ab8f37
@Michicosun
fix
7e64a3f
@Michicosun
make due times const ref
a05bffc
@Michicosun
remove static
61a2a3f
@Michicosun
persist
d4908b4
@Michicosun
mv
03534b3
@Michicosun
use level from part info
802cf59
@Michicosun
change collector api
f682b1b
@Michicosun
simplify applier
39599ac
@Michicosun
fixate all non-constant parameters before collector
6ee367b
@Michicosun
include only non-empty ranges
743f1ea
@Michicosun
update combinator
df92cb5
@Michicosun
fix applier choice path
71e3e94
@Michicosun
add tl to dbms deps
81e6654
@Michicosun
add all_ttl_calculated_if_any to properties
add12df
@Michicosun
change merger mutator
bad66c8
@Michicosun
add parts finders
b6741d6
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 13, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Dec 13, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit ad88456 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Michicosun Michicosun marked this pull request as draft December 16, 2024 21:26
alesapin
alesapin approved these changes Jan 10, 2025
View reviewed changes
@Michicosun Michicosun added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit 04536ab Jan 13, 2025
224 of 227 checks passed
@Michicosun Michicosun deleted the split_merger_mutator branch January 13, 2025 12:39
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 13, 2025
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jan 14, 2025
@baibaichen
Fix build due to ClickHouse/ClickHouse#73294
ed3734f
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jan 15, 2025
@baibaichen
Fix build due to ClickHouse/ClickHouse#73294
bf2b836
baibaichen added a commit to apache/incubator-gluten that referenced this pull request Jan 15, 2025
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20250115) (#8537)
71a22da 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250115)

* Fix build due to ClickHouse/ClickHouse#73294

* Fix UT due to ClickHouse/ClickHouse#70102

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@Algunenano
Copy link
Member

Algunenano commented Jan 17, 2025

Do we really need this amount of logs?

2025.01.17 13:38:06.731414 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241218_1_1_0 and 20241219_2_2_0. Reason: Parts 20241218_1_1_0 and 20241219_2_2_0 belong to different partitions
2025.01.17 13:38:06.731426 [ 271270 ] {} <Debug> AsyncLoader: Execute load job 'startup table test_qlaexa9z.distributed' in ForegroundLoad
2025.01.17 13:38:06.731433 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241219_2_2_0 and 20241220_3_3_0. Reason: Parts 20241219_2_2_0 and 20241220_3_3_0 belong to different partitions
2025.01.17 13:38:06.731442 [ 271270 ] {} <Debug> AsyncLoader: Finish load job 'startup table test_qlaexa9z.distributed' with status OK
2025.01.17 13:38:06.731425 [ 270675 ] {} <Debug> default.sample_table (ad30a999-05c9-40e9-8094-e876f24e8658): Failed to start merge: There is no need to merge parts according to merge selector algorithm
2025.01.17 13:38:06.731454 [ 271270 ] {} <Debug> AsyncLoader: Execute load job 'startup table ch_main.__t_gkd5z7uay' in ForegroundLoad
2025.01.17 13:38:06.731449 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241220_3_3_0 and 20241221_4_4_0. Reason: Parts 20241220_3_3_0 and 20241221_4_4_0 belong to different partitions
2025.01.17 13:38:06.731472 [ 271281 ] {} <Debug> AsyncLoader: Execute load job 'startup Ordinary database test_9xmghoac' in ForegroundLoad
2025.01.17 13:38:06.731475 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241221_4_4_0 and 20241222_5_5_0. Reason: Parts 20241221_4_4_0 and 20241222_5_5_0 belong to different partitions
2025.01.17 13:38:06.731489 [ 271281 ] {} <Debug> AsyncLoader: Finish load job 'startup Ordinary database test_9xmghoac' with status OK
2025.01.17 13:38:06.731504 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241222_5_5_0 and 20241223_6_6_0. Reason: Parts 20241222_5_5_0 and 20241223_6_6_0 belong to different partitions
2025.01.17 13:38:06.731509 [ 271281 ] {} <Debug> AsyncLoader: Execute load job 'startup table test.visits' in ForegroundLoad
2025.01.17 13:38:06.731522 [ 270674 ] {} <Trace> default.bug_13492 (373b473c-bb9d-491d-99e6-3feaa338452c) (MergerMutator): Can't merge parts 20241223_6_6_0 and 20241224_7_7_0. Reason: Parts 20241223_6_6_0 and 20241224_7_7_0 belong to different partitions
2025.01.17 13:38:06.731533 [ 271245 ] {} <Debug> AsyncLoader: Execute load job 'startup table default.perf_avg' in ForegroundLoad

2025.01.17 13:40:21.756812 [ 270834 ] {} <Debug> system.crash_log (8368a993-0196-47e0-ab9f-8d9ac284fefc): Failed to start merge: There is no need to merge parts according to merge selector algorithm
2025.01.17 13:40:21.769695 [ 270836 ] {} <Debug> default.perf_avg (14ea0ebf-0507-4f37-b194-45ec005bd1a5): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:21.825196 [ 270837 ] {} <Debug> system.text_log_1 (d0e74408-261c-4671-a495-db1d4bc78693): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:21.906052 [ 270838 ] {} <Debug> system.query_log_1 (63482a23-e7c3-4588-84ab-afcae821f2c8): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:21.909414 [ 270839 ] {} <Debug> system.zookeeper_log_26 (fe4251af-fdce-45e9-954f-78d60aeac084): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:22.030184 [ 270840 ] {} <Debug> system.part_log_0 (e1df0b28-0839-4a2d-8dc9-28cdb4f60d10): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:22.043662 [ 270841 ] {} <Debug> system.zookeeper_log_18 (ac37445a-18c5-4be1-b395-ca54be9fbb4a): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:22.083888 [ 270843 ] {} <Debug> system.zookeeper_log_25 (b585f51c-1bde-4109-8bb0-e59c993d1cd6): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)
2025.01.17 13:40:22.127868 [ 270844 ] {} <Debug> ch_main.__t_kjklp05ed (660f0cbc-ee0c-45cb-9ad7-f2fcade83d61): Failed to start merge: There are no parts that can be merged. (Collector returned empty ranges set)

Is it really useful to have this spamming all the time?

@Michicosun
Copy link
Member Author

Michicosun commented Jan 17, 2025 •
edited
Loading

Is it really useful to have this spamming all the time?

You think that's too much? It writes this log no more than once every 10 seconds. We can increase it to 1 minute I think.

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jan 20, 2025

Yes, it is too much.

@alexey-milovidov alexey-milovidov mentioned this pull request Jan 20, 2025
Merged
8 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jun 10, 2025
@Michicosun @zvonand
Merge pull request ClickHouse#73294 from ClickHouse/split_merger_mutator
de77925 
Make MergerMutator more customizable
@aalexfvk aalexfvk mentioned this pull request Aug 14, 2025
Closed
@DerekChia DerekChia mentioned this pull request Sep 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

@alesapin alesapin

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Michicosun @robot-ch-test-poll3 @Algunenano @alexey-milovidov @alesapin @robot-ch-test-poll1 @robot-clickhouse-ci-1