Skip to content

Skipping index cache #70102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rschu1ze merged 10 commits into from
Jan 13, 2025
Merged

Skipping index cache #70102

rschu1ze merged 10 commits into from
Jan 13, 2025

Conversation

@rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Sep 28, 2024

The original PR got stuck, refreshing it. Kudos to @al13n321

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added an in-memory cache for deserialized skipping index granules. This should make repeated queries that use skipping indexes faster. The size of the new cache is controlled by server settings skipping_index_cache_size and skipping_index_cache_max_entries. The original motivation for the cache were vector similarity indexes which became a lot faster now.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@rschu1ze rschu1ze mentioned this pull request Sep 28, 2024
Closed
1 task
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Sep 28, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Sep 28, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 86eb315 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@novikd novikd self-assigned this Sep 30, 2024
novikd

This comment was marked as resolved.

Sign in to view

@robot-ch-test-poll2 robot-ch-test-poll2 added the submodule changed At least one submodule changed in this PR. label Nov 18, 2024
@rschu1ze rschu1ze force-pushed the skipping-index-cache2 branch from a692bfb to 14aa136 Compare November 18, 2024 22:28
@robot-ch-test-poll4 robot-ch-test-poll4 removed the submodule changed At least one submodule changed in this PR. label Nov 18, 2024
@rschu1ze rschu1ze force-pushed the skipping-index-cache2 branch 2 times, most recently from 4f3d1c7 to c051e85 Compare November 18, 2024 22:45
@rschu1ze

This comment was marked as resolved.

Sign in to view
@rschu1ze rschu1ze force-pushed the skipping-index-cache2 branch from c051e85 to f521b25 Compare November 18, 2024 22:48
@rschu1ze rschu1ze force-pushed the skipping-index-cache2 branch from f521b25 to fa81342 Compare November 18, 2024 22:54
@rschu1ze rschu1ze mentioned this pull request Dec 2, 2024
Open
@clickhouse-gh
Copy link

clickhouse-gh bot commented Jan 7, 2025

Dear @novikd, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@novikd novikd self-assigned this Jan 7, 2025
@rschu1ze
Copy link
Member Author

rschu1ze commented Jan 13, 2025

ClickHouse Stateless tests (ubsan) [2/2]:

ClickHouse Integration tests (aarch64) [5/6]:

@rschu1ze rschu1ze added this pull request to the merge queue Jan 13, 2025
Merged via the queue into ClickHouse:master with commit 3de5611 Jan 13, 2025
205 of 221 checks passed
@rschu1ze rschu1ze deleted the skipping-index-cache2 branch January 13, 2025 17:30
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 13, 2025
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jan 14, 2025
@baibaichen
Fix UT due to ClickHouse/ClickHouse#70102
7b1faf1
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jan 15, 2025
@baibaichen
Fix UT due to ClickHouse/ClickHouse#70102
89a72a1
baibaichen added a commit to apache/incubator-gluten that referenced this pull request Jan 15, 2025
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20250115) (#8537)
71a22da 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250115)

* Fix build due to ClickHouse/ClickHouse#73294

* Fix UT due to ClickHouse/ClickHouse#70102

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
This was referenced Jan 20, 2025
Open
Open
@shiyer7474 shiyer7474 mentioned this pull request Jan 21, 2025
Closed
20 tasks
nikitamikhaylov added a commit that referenced this pull request Mar 11, 2025
@nikitamikhaylov
Revert "Merge pull request #70102 from rschu1ze/skipping-index-cache2"
0003892 
This reverts commit 3de5611, reversing
changes made to 987f678.
@Algunenano Algunenano mentioned this pull request Mar 11, 2025
Merged
1 task
shankar-iyer added a commit to shankar-iyer/ClickHouse that referenced this pull request Mar 19, 2025
@shankar-iyer
Reapply "Merge pull request ClickHouse#70102 from rschu1ze/skipping-i…
3432e3f 
…ndex-cache2"

This reverts commit 0003892.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd left review comments

Assignees

@novikd novikd

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rschu1ze @robot-ch-test-poll @novikd @robot-ch-test-poll2 @robot-ch-test-poll4