Skip to content

Enable use_hive_partitioning by default#71636

Merged
alexey-milovidov merged 10 commits intoClickHouse:masterfrom
yariks5s:hive_partitioning_default
Jan 1, 2025
Merged

Enable use_hive_partitioning by default#71636
alexey-milovidov merged 10 commits intoClickHouse:masterfrom
yariks5s:hive_partitioning_default

Conversation

@yariks5s
Copy link
Copy Markdown
Member

@yariks5s yariks5s commented Nov 8, 2024 •
edited by alexey-milovidov
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Enables setting use_hive_partitioning by default.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 8, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Nov 8, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit ca99681 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this Nov 8, 2024
antaljanosbenjamin
antaljanosbenjamin reviewed Nov 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry, apart from that it is good.

@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Nov 8, 2024

@antaljanosbenjamin done.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Nov 11, 2024
@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Nov 13, 2024 •
edited
Loading

Needs #71889

Upd: that PR is merged

@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Nov 20, 2024 •
edited
Loading

Needs #72185

Upd: that PR is also merged now.

@yariks5s yariks5s mentioned this pull request Dec 17, 2024
Merged
21 tasks
@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Dec 18, 2024 •
edited
Loading

Needs #73479

Upd: also merged

@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Dec 24, 2024 •
edited
Loading

Needs #73804

Upd: merged

@yariks5s yariks5s mentioned this pull request Dec 30, 2024
Closed
22 tasks
@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2024
Closed
76 tasks
@yariks5s
Copy link
Copy Markdown
Member Author

yariks5s commented Jan 1, 2025

test_memory_limit/test.py::test_multiple_queries is flaky on master

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jan 1, 2025
Merged via the queue into ClickHouse:master with commit 766bcbf Jan 1, 2025
@yariks5s yariks5s deleted the hive_partitioning_default branch January 1, 2025 16:20
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 1, 2025
@gingerwizard gingerwizard mentioned this pull request Jan 6, 2025
Merged
arthurpassos pushed a commit to Altinity/ClickHouse that referenced this pull request Apr 2, 2025
@alexey-milovidov @arthurpassos
Merge pull request ClickHouse#71636 from yariks5s/hive_partitioning_d…
6324f8f 
…efault

Enable `use_hive_partitioning` by default
This was referenced Apr 2, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

Assignees

@antaljanosbenjamin antaljanosbenjamin

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yariks5s @robot-ch-test-poll2 @antaljanosbenjamin @alexey-milovidov @robot-ch-test-poll1 @robot-clickhouse-ci-1