Forbid to create tables as *Cluster#73804
Merged
yariks5s merged 10 commits intoClickHouse:masterfrom Dec 31, 2024
Merged
Conversation
Contributor
|
This is an automated comment for commit a2a1192 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
*Cluster engines*Cluster table functions
*Cluster table functions*Cluster
21 tasks
Avogar
reviewed
Dec 27, 2024
Co-authored-by: Pavel Kruglov <48961922+Avogar@users.noreply.github.com>
Avogar
approved these changes
Dec 27, 2024
Member
|
@yariks5s Please check the remaining table functions as well, e.g. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason is that
*Clusterare not a table engines, but a table functions. Using those tables can lead to logical errors:Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
CI Settings (Only check the boxes if you know what you are doing)
All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below: