Skip to content

Stateless tests: deal with hang-ups more roughly#66411

Merged
fm4v merged 5 commits intomasterfrom
fix-hanging-on-gdb
Jul 12, 2024
Merged

Stateless tests: deal with hang-ups more roughly#66411
fm4v merged 5 commits intomasterfrom
fix-hanging-on-gdb

Conversation

@fm4v
Copy link
Copy Markdown
Member

@fm4v fm4v commented Jul 11, 2024 •
edited
Loading

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Tests: fix tests hang up in cases when gdb catches error

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@fm4v fm4v added the can be tested Allows running workflows for external contributors label Jul 11, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-build Pull request with build/testing/packaging improvement label Jul 11, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 11, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit dd6dac6 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@fm4v
Copy link
Copy Markdown
Member Author

fm4v commented Jul 12, 2024

Job with gdb error is not hanging anymore and only 1 test is marked as FAILED:
https://s3.amazonaws.com/clickhouse-test-reports/66411/72037d0fbbd3dd25190a6c050aa87e58123f62fa/stateless_tests__debug__[1_2].html
https://s3.amazonaws.com/clickhouse-test-reports/66411/72037d0fbbd3dd25190a6c050aa87e58123f62fa/stateless_tests__debug__[2_2].html

@fm4v fm4v force-pushed the fix-hanging-on-gdb branch from c363f90 to 72037d0 Compare July 12, 2024 01:03
@fm4v fm4v force-pushed the fix-hanging-on-gdb branch from 72037d0 to 08b6dd6 Compare July 12, 2024 01:04
@fm4v fm4v added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 258ae45 Jul 12, 2024
@fm4v fm4v deleted the fix-hanging-on-gdb branch July 12, 2024 14:31
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 12, 2024
@azat azat mentioned this pull request Aug 3, 2024
Merged
azat
azat reviewed Aug 3, 2024
View reviewed changes
tests/clickhouse-test
args, test_suite, client_options, server_logs_level
)
test_result = test_case.process_result(test_result, MESSAGES)
break
Copy link
Copy Markdown
Member

@azat azat Aug 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azat added a commit to azat/ClickHouse that referenced this pull request Oct 25, 2024
@azat
Fix clickhouse-test useless 5 second delay in case of multiple thread…
e898a52 
…s are used

Fixes: ClickHouse#66411
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat mentioned this pull request Oct 25, 2024
Merged
azat added a commit to azat/ClickHouse that referenced this pull request Oct 25, 2024
@azat
Fix clickhouse-test useless 5 second delay in case of multiple thread…
786ba7a 
…s are used

Fixes: ClickHouse#66411
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@fm4v fm4v self-assigned this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@fm4v fm4v

Labels

can be tested Allows running workflows for external contributors pr-build Pull request with build/testing/packaging improvement pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fm4v @robot-ch-test-poll @azat @antonio2368 @robot-ch-test-poll4 @robot-clickhouse-ci-1