Skip to content

Fix test retries#67738

Merged
fm4v merged 1 commit intoClickHouse:masterfrom
azat:tests/fix-retries
Aug 4, 2024
Merged

Fix test retries#67738
fm4v merged 1 commit intoClickHouse:masterfrom
azat:tests/fix-retries

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 3, 2024

Should fix issues like:

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #66411 (cc @fm4v )

@azat
Fix test retries
a197502 
Should fix issues like:
- 02494_zero_copy_projection_cancel_fetch - https://s3.amazonaws.com/clickhouse-test-reports/67719/40cd5467c18d65a6624d273ac1a8fd9cc9257d8c/stateless_tests__tsan__s3_storage__[4_4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat mentioned this pull request Aug 3, 2024
Merged
19 tasks
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 3, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Aug 3, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit a197502 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 4, 2024

CI is green

@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Aug 4, 2024
@fm4v fm4v added this pull request to the merge queue Aug 4, 2024
Merged via the queue into ClickHouse:master with commit c6c4b31 Aug 4, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 4, 2024
@azat azat deleted the tests/fix-retries branch August 4, 2024 19:48
@azat azat mentioned this pull request Aug 7, 2024
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created-cloud deprecated label, NOOP label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@azat @robot-clickhouse-ci-1 @alesapin @fm4v @robot-clickhouse @robot-clickhouse-ci-2