Skip to content

Ignore subquery for IN in DDLLoadingDependencyVisitor#66395

Merged
KochetovNicolai merged 1 commit intomasterfrom
continue-66261
Jul 12, 2024
Merged

Ignore subquery for IN in DDLLoadingDependencyVisitor#66395
KochetovNicolai merged 1 commit intomasterfrom
continue-66261

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jul 11, 2024 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Continuation for #66261
Closes #66390

@KochetovNicolai KochetovNicolai mentioned this pull request Jul 11, 2024
Closed
@KochetovNicolai KochetovNicolai added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 11, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 11, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Jul 11, 2024 •
edited
Loading

This is an automated comment for commit 1bc02fb with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@evillique evillique self-assigned this Jul 11, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 12, 2024
@KochetovNicolai KochetovNicolai added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit 27dc6a6 Jul 12, 2024
@KochetovNicolai KochetovNicolai deleted the continue-66261 branch July 12, 2024 08:50
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 12, 2024
This was referenced Jul 12, 2024
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse
Backport #66395 to 24.3: Ignore subquery for IN in DDLLoadingDependen…
5a05914 
…cyVisitor
This was referenced Jul 12, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse
Backport #66395 to 24.4: Ignore subquery for IN in DDLLoadingDependen…
9e273cc 
…cyVisitor
This was referenced Jul 12, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse
Backport #66395 to 24.5: Ignore subquery for IN in DDLLoadingDependen…
0ca63d5 
…cyVisitor
This was referenced Jul 12, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse
Backport #66395 to 24.6: Ignore subquery for IN in DDLLoadingDependen…
f467283 
…cyVisitor
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 12, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Jul 12, 2024
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Jul 12, 2024
Merged
19 tasks
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse-ci-1
Merge pull request #66426 from ClickHouse/backport/24.5/66395
6034aa4 
Backport #66395 to 24.5: Ignore subquery for IN in DDLLoadingDependencyVisitor
robot-clickhouse added a commit that referenced this pull request Jul 12, 2024
@robot-clickhouse
Merge pull request #66428 from ClickHouse/backport/24.6/66395
386b103 
Backport #66395 to 24.6: Ignore subquery for IN in DDLLoadingDependencyVisitor
robot-ch-test-poll1 added a commit that referenced this pull request Jul 12, 2024
@robot-ch-test-poll1
Merge pull request #66424 from ClickHouse/backport/24.4/66395
b92f9a9 
Backport #66395 to 24.4: Ignore subquery for IN in DDLLoadingDependencyVisitor
robot-ch-test-poll1 added a commit that referenced this pull request Jul 12, 2024
@robot-ch-test-poll1
Merge pull request #66422 from ClickHouse/backport/24.3/66395
02517b7 
Backport #66395 to 24.3: Ignore subquery for IN in DDLLoadingDependencyVisitor
@vitlibar vitlibar mentioned this pull request Jul 12, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

assert(false) in DB::DDLLoadingDependencyVisitor::extractTableNameFromArgument

6 participants

@KochetovNicolai @robot-ch-test-poll4 @evillique @robot-ch-test-poll @robot-ch-test-poll1 @robot-ch-test-poll3