Skip to content

Fixing Not-ready set in constraint.#66261

Merged
KochetovNicolai merged 1 commit intomasterfrom
not-ready-set-constraints
Jul 10, 2024
Merged

Fixing Not-ready set in constraint.#66261
KochetovNicolai merged 1 commit intomasterfrom
not-ready-set-constraints

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jul 9, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix the Not-ready set error when a subquery with IN is used in the constraint.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 9, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jul 9, 2024 •
edited
Loading

This is an automated comment for commit 0174a43 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nickitat nickitat self-assigned this Jul 9, 2024
nickitat
nickitat approved these changes Jul 9, 2024
View reviewed changes
tests/queries/0_stateless/02841_not_ready_set_constraints.sql

CREATE TABLE t2 (
`conversation` UInt64,
CONSTRAINT constraint_conversation CHECK conversation IN (SELECT id FROM t1)
Copy link
Copy Markdown
Member

@nickitat nickitat Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would there be any difference from planner's POV if this set will not be a single constant? if yes, prob makes sense to add this test case too.

Copy link
Copy Markdown
Member Author

@KochetovNicolai KochetovNicolai Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No difference for a planner. It is still a set.

@KochetovNicolai KochetovNicolai added this pull request to the merge queue Jul 10, 2024
@KochetovNicolai KochetovNicolai added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 10, 2024
Merged via the queue into master with commit 04e83de Jul 10, 2024
@KochetovNicolai KochetovNicolai deleted the not-ready-set-constraints branch July 10, 2024 16:19
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 10, 2024
This was referenced Jul 10, 2024
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jul 10, 2024
@robot-clickhouse
Backport #66261 to 24.3: Fixing Not-ready set in constraint.
7d3b7f8
This was referenced Jul 10, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 10, 2024
@robot-clickhouse
Backport #66261 to 24.4: Fixing Not-ready set in constraint.
38536dd
This was referenced Jul 10, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 10, 2024
@robot-clickhouse
Backport #66261 to 24.5: Fixing Not-ready set in constraint.
9431e07
This was referenced Jul 10, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 10, 2024
@robot-clickhouse
Backport #66261 to 24.6: Fixing Not-ready set in constraint.
b5b72e5
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jul 10, 2024
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Jul 10, 2024
robot-ch-test-poll2 added a commit that referenced this pull request Jul 10, 2024
@robot-ch-test-poll2
Merge pull request #66362 from ClickHouse/backport/24.6/66261
374ac7a 
Backport #66261 to 24.6: Fixing Not-ready set in constraint.
robot-ch-test-poll1 added a commit that referenced this pull request Jul 11, 2024
@robot-ch-test-poll1
Merge pull request #66358 from ClickHouse/backport/24.4/66261
66675c7 
Backport #66261 to 24.4: Fixing Not-ready set in constraint.
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 11, 2024
@KochetovNicolai KochetovNicolai mentioned this pull request Jul 11, 2024
Merged
KochetovNicolai added a commit that referenced this pull request Jul 11, 2024
@KochetovNicolai
Merge pull request #66356 from ClickHouse/backport/24.3/66261
b22ed81 
Backport #66261 to 24.3: Fixing Not-ready set in constraint.
KochetovNicolai added a commit that referenced this pull request Jul 11, 2024
@KochetovNicolai
Merge pull request #66360 from ClickHouse/backport/24.5/66261
bcf12ef 
Backport #66261 to 24.5: Fixing Not-ready set in constraint.
@den-crane den-crane mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@KochetovNicolai @robot-clickhouse-ci-1 @nickitat @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-clickhouse-ci-2