Skip to content

Fix formatting for JOIN ON clause with alias for the whole expression#66378

Closed
azat wants to merge 2 commits intoClickHouse:masterfrom
azat:join-on-formatting
Closed

Fix formatting for JOIN ON clause with alias for the whole expression#66378
azat wants to merge 2 commits intoClickHouse:masterfrom
azat:join-on-formatting

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 11, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix formatting for JOIN ON clause with alias for the whole expression

@azat
Fix formatting for JOIN ON clause with alias for the whole expression
738c0b1 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat mentioned this pull request Jul 11, 2024
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 11, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jul 11, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 37c26b3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@evillique evillique self-assigned this Jul 11, 2024
This was referenced Jul 13, 2024
Merged
Closed
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 13, 2024

@azat, we want to merge this pull request, but unfortunately one test in the private repository timed out when tested with S3 storage (probably due to the slowness of Minio over EBS volumes). Could you please merge with the master branch again?

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 14, 2024

@azat, could you please check why builds didn't finish?

@azat azat mentioned this pull request Jul 22, 2024
Merged
19 tasks
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 22, 2024

Closed in favor of #66312

@azat azat closed this Jul 22, 2024
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 22, 2024 •
edited
Loading

https://s3.amazonaws.com/clickhouse-test-reports/66378/37c26b302d66111323ee464a7c0c7f1f45e968f1/stateless_tests__release_.html

2024.07.14 08:21:52.030940 [ 3316 ] {} Application: Child process was stopped by signal 19.

19 - SIGSTOP

Although I don't see any traces in gdb, I'm waiting for gdb upgrade - #66494

vdimir added a commit that referenced this pull request Jul 23, 2024
@vdimir @azat
Add test from #66378
d7ffbab 
Co-authored-by: Azat Khuzhin <a.khuzhin@semrush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-clickhouse-ci-2 @alexey-milovidov @evillique @robot-ch-test-poll3