Skip to content

Fix aliased JOIN ON expression formatting#66312

Merged
vdimir merged 6 commits intomasterfrom
vdimir/proper_fix_join_on_nullsafe_optimization
Jul 27, 2024
Merged

Fix aliased JOIN ON expression formatting#66312
vdimir merged 6 commits intomasterfrom
vdimir/proper_fix_join_on_nullsafe_optimization

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 10, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix formatting of query with aliased JOIN ON expression, e.g. ... JOIN t2 ON (x = y) AS e ORDER BY x should be formatted as ... JOIN t2 ON ((x = y) AS e) ORDER BY x

Proper fix for #66310

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@vdimir vdimir changed the title Disable broken cases from 02911_join_on_nullsafe_optimization Fix aliased JOIN ON expression formatting Jul 10, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 10, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jul 10, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit a59036e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Successful checks
Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir mentioned this pull request Jul 10, 2024
Merged
19 tasks
@novikd novikd self-assigned this Jul 10, 2024
@Algunenano Algunenano mentioned this pull request Jul 10, 2024
Merged
21 tasks
@kssenii kssenii mentioned this pull request Jul 11, 2024
Merged
19 tasks
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 11, 2024

AST fuzzer (debug) — Logical error: 'Inconsistent AST formatting: the query: Details

Another occurrence of the same error:

2024.07.10 15:30:05.225781 [ 1228 ] {7e4f70eb-18ec-4c99-9a9f-c24c3ea72188} <Fatal> : Logical error: 'Inconsistent AST formatting: the query:
SELECT toNullable(toUInt256(5)), '-------- MultiPolygon with Polygon', 34, 34 GROUP BY GROUPING SETS ((concat([materialize((25.001, 136.9987))])), ([[[(4.344961, 50.833264), c -> ([[[(4.366227, 50.840809), (4.344961, 50.833264), (4.338074, 50.848677), (4.346693, 50.858306)]]], round(c.1), round(6)), (4.346693, 50.858306)]]]), (((0 + toUInt128(1)) + 2) + 3))
cannot parse.'.

@vdimir vdimir enabled auto-merge July 16, 2024 10:20
@vdimir vdimir disabled auto-merge July 18, 2024 15:15
@vdimir vdimir enabled auto-merge July 18, 2024 15:15
@azat
Copy link
Copy Markdown
Member

azat commented Jul 22, 2024

Same as #66378

@azat
Copy link
Copy Markdown
Member

azat commented Jul 22, 2024

@vdimir can you also add a test from my PR?

@azat azat mentioned this pull request Jul 22, 2024
Closed
@vdimir @azat
Add test from #66378
d7ffbab 
Co-authored-by: Azat Khuzhin <a.khuzhin@semrush.com>
@vdimir vdimir mentioned this pull request Jul 26, 2024
Merged
19 tasks
@vdimir vdimir added this pull request to the merge queue Jul 27, 2024
Merged via the queue into master with commit 7c7783e Jul 27, 2024
@vdimir vdimir deleted the vdimir/proper_fix_join_on_nullsafe_optimization branch July 27, 2024 01:25
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@novikd novikd

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vdimir @robot-ch-test-poll2 @azat @novikd @alexey-milovidov @robot-ch-test-poll @robot-clickhouse-ci-2