Skip to content

Disable broken cases from 02911_join_on_nullsafe_optimization#66310

Merged
vdimir merged 2 commits intomasterfrom
vdimir/fix_join_on_nullsafe_optimization
Jul 11, 2024
Merged

Disable broken cases from 02911_join_on_nullsafe_optimization#66310
vdimir merged 2 commits intomasterfrom
vdimir/fix_join_on_nullsafe_optimization

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 10, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Disable queries that uncovers logical error until it's fixed

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@vdimir vdimir mentioned this pull request Jul 10, 2024
Merged
19 tasks
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 10, 2024
@vdimir vdimir added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 10, 2024
@vdimir vdimir force-pushed the vdimir/fix_join_on_nullsafe_optimization branch from b8ab971 to 513ce9f Compare July 10, 2024 08:56
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jul 10, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit cbaa264 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir mentioned this pull request Jul 10, 2024
Merged
19 tasks
@vdimir vdimir self-assigned this Jul 10, 2024
@vdimir vdimir added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit e1ad5c7 Jul 11, 2024
@vdimir vdimir deleted the vdimir/fix_join_on_nullsafe_optimization branch July 11, 2024 09:07
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 11, 2024
This was referenced Jul 11, 2024
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jul 11, 2024
@robot-clickhouse
Backport #66310 to 24.4: Disable broken cases from 02911_join_on_null…
233f0b6 
…safe_optimization
This was referenced Jul 11, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 11, 2024
@robot-clickhouse
Backport #66310 to 24.5: Disable broken cases from 02911_join_on_null…
577a163 
…safe_optimization
This was referenced Jul 11, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jul 11, 2024
@robot-clickhouse
Backport #66310 to 24.6: Disable broken cases from 02911_join_on_null…
ad93d92 
…safe_optimization
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jul 11, 2024
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 11, 2024
@robot-clickhouse-ci-1
Merge pull request #66389 from ClickHouse/backport/24.6/66310
acc94ef 
Backport #66310 to 24.6: Disable broken cases from 02911_join_on_nullsafe_optimization
vdimir added a commit that referenced this pull request Jul 11, 2024
@vdimir
Merge pull request #66385 from ClickHouse/backport/24.4/66310
3ef3c5f 
Backport #66310 to 24.4: Disable broken cases from 02911_join_on_nullsafe_optimization
vdimir added a commit that referenced this pull request Jul 11, 2024
@vdimir
Merge pull request #66387 from ClickHouse/backport/24.5/66310
015ba07 
Backport #66310 to 24.5: Disable broken cases from 02911_join_on_nullsafe_optimization
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Jul 11, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 12, 2024
@CheSema CheSema mentioned this pull request Jul 26, 2024
Closed
@CheSema
Copy link
Copy Markdown
Member

CheSema commented Jul 26, 2024

Do we have an issue with the context what should be fixed?
Otherwise it looks like you just hid the repro. :(

@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 26, 2024

Do we have an issue with the context what should be fixed? Otherwise it looks like you just hid the repro. :(

@CheSema

yes, fixing and enabling tests back in #66312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vdimir vdimir

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vdimir @robot-ch-test-poll1 @CheSema @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-ch-test-poll3