Skip to content

Use peak_threads_usage instead of arrayUniq(thread_ids) in tests#66162

Merged
CheSema merged 1 commit intoClickHouse:masterfrom
azat:tests/peak_threads_usage
Jul 10, 2024
Merged

Use peak_threads_usage instead of arrayUniq(thread_ids) in tests#66162
CheSema merged 1 commit intoClickHouse:masterfrom
azat:tests/peak_threads_usage

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 5, 2024 •
edited
Loading

Should fix flakiness like 1.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #66116

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: Stateless tests

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 5, 2024
@nickitat nickitat mentioned this pull request Jul 5, 2024
Closed
@azat azat force-pushed the tests/peak_threads_usage branch from e4b2a0f to daae5d4 Compare July 5, 2024 18:47
@alexey-milovidov alexey-milovidov self-assigned this Jul 5, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jul 5, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 61e50a3 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 5, 2024

@azat, Could you please merge with the master branch? We upgraded the compiler and it started to find one more issue by clang-tidy, which was fixed in the master branch.

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 6, 2024

@alexey-milovidov the compiler hadn't been upgraded yet, it is done in #66070 and it hasn't been merged yet, it also fixes the tidy issues

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 6, 2024

Stateless tests (aarch64) — fail: 1, passed: 6701, skipped: 17

P.S. And this PR should be created with Allow: Stateless tests only I guess to avoid this annoying failed checks

CheSema
CheSema reviewed Jul 6, 2024
View reviewed changes
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 6, 2024

We want to get rid of all flaky tests. It makes sense to run even trivial PRs with all checks to find out if some tests are still flaky and then have a huge pain fixing all of them.

@azat azat marked this pull request as draft July 6, 2024 14:01
@azat azat force-pushed the tests/peak_threads_usage branch from daae5d4 to 61e50a3 Compare July 9, 2024 14:13
@azat azat marked this pull request as ready for review July 9, 2024 14:13
@CheSema CheSema assigned CheSema and unassigned alexey-milovidov Jul 9, 2024
@CheSema CheSema added this pull request to the merge queue Jul 10, 2024
Merged via the queue into ClickHouse:master with commit 48a47e5 Jul 10, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 10, 2024
@azat azat deleted the tests/peak_threads_usage branch August 1, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@CheSema CheSema CheSema approved these changes

Assignees

@CheSema CheSema

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky 01275_parallel_mv

6 participants

@azat @robot-clickhouse-ci-1 @alexey-milovidov @CheSema @robot-clickhouse @robot-ch-test-poll4