Skip to content

Pin all python packages in CI images and do some dirty job with clang version#66070

Merged
alesapin merged 15 commits intomasterfrom
pin_python_packages
Jul 6, 2024
Merged

Pin all python packages in CI images and do some dirty job with clang version#66070
alesapin merged 15 commits intomasterfrom
pin_python_packages

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jul 3, 2024 •
edited
Loading

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Use pinned versions of all python packages in CI docker images. Also makes clang-18.1.8 work with sanitizers and surprisingly fixes #66049.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jul 3, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit f94076c with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 4, 2024

Didn't help. Probably we have to take clang from github releases, because for deb repo llvm intentionally remove older patches. Right now only 18.1.8 is available.

azat
azat reviewed Jul 4, 2024
View reviewed changes
azat
azat reviewed Jul 4, 2024
View reviewed changes
alesapin and others added 2 commits July 4, 2024 15:48
@alesapin @azat
Update docker/test/fasttest/Dockerfile
1af3caf 
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
@alesapin
Revert "Update docker/test/fasttest/Dockerfile"
963f39e 
This reverts commit 1af3caf.
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 4, 2024 •
edited
Loading

Oh god, they as well have different names:

Jul 04 16:42:17 ld.lld-18: error: cannot open /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan-x86_64.a: No such file or directory
Jul 04 16:42:17 ld.lld-18: error: cannot open /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan_cxx-x86_64.a: No such file or directory

and

-rw-r--r-- 1 root root 3103232 Jun 16 00:38 /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan.a
-rw-r--r-- 1 root root  105612 Jun 16 00:38 /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan.a.syms
-rw-r--r-- 1 root root   32498 Jun 16 00:38 /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan_cxx.a
-rw-r--r-- 1 root root     488 Jun 16 00:38 /usr/lib/llvm-18/lib/clang/18/lib/linux/libclang_rt.msan_cxx.a.syms

@azat
Copy link
Copy Markdown
Member

azat commented Jul 5, 2024

@alesapin

Pin all python packages in CI images

Also now it is not only "python packages"

azat
azat reviewed Jul 5, 2024
View reviewed changes
@alesapin alesapin changed the title Pin all python packages in CI images Pin all python packages in CI images and do some dirty job with clang version Jul 5, 2024
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 5, 2024

Yaaaar

Jul 05 20:32:18 FAILED: src/CMakeFiles/clickhouse_common_io.dir/IO/WriteBufferFromS3.cpp.o 
Jul 05 20:32:18 /usr/bin/cmake -E __run_co_compile --launcher="prlimit;--as=10000000000;--data=5000000000;--cpu=1000;/usr/bin/sccache" --tidy="/usr/bin/clang-tidy-cache;/usr/bin/clang-tidy-18;--extra-arg-before=--driver-mode=g++" --source=/build/src/IO/WriteBufferFromS3.cpp -- /usr/bin/clang++-18 --target=x86_64-linux-gnu --sysroot=/build/cmake/linux/../../contrib/sysroot/linux-x86_64/x86_64-linux-gnu/libc -DBOOST_ASIO_HAS_STD_INVOKE_RESULT=1 -DBOOST_ASIO_STANDALONE=1 -DBOOST_TIMER_ENABLE_DEPRECATED=1 -DCARES_STATICLIB -DDUMMY_BACKTRACE -DENABLE_MULTITARGET_CODE=1 -DENABLE_ZSTD_QAT_CODEC -DHAVE_BZLIB_H=1 -DHAVE_CONFIG_H -DHAVE_FUTIMESAT=1 -DHAVE_ICONV=1 -DHAVE_LIBLZMA=1 -DHAVE_LIBZSTD=1 -DHAVE_LIBZSTD_COMPRESSOR=1 -DHAVE_LINUX_FS_H=1 -DHAVE_LINUX_TYPES_H=1 -DHAVE_LZMA_H=1 -DHAVE_STRUCT_STAT_ST_MTIM_TV_NSEC=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_ZLIB_H=1 -DHAVE_ZSTD_H=1 -DINCBIN_SILENCE_BITCODE_WARNING -DINTREE -DLZ4_DISABLE_DEPRECATE_WARNINGS=1 -DLZ4_FAST_DEC_LOOP=1 -DMAJOR_IN_SYSMACROS=1 -DMZ_COMPAT_VERSION=110 -DPOCO_ENABLE_CPP11 -DPOCO_HAVE_FD_EPOLL -DPOCO_OS_FAMILY_UNIX -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -DUNALIGNED_OK -DWITH_COVERAGE=0 -DWITH_GZFILEOP -DX86_64 -DZLIB_COMPAT -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_LIBUNWIND_IS_NATIVE_ONLY -I/build/build_docker/includes/configs -I/build/src -I/build/build_docker/src -I/build/build_docker/src/Core/include -I/build/base/glibc-compatibility/memcpy -I/build/base/widechar_width -I/build/base/base/.. -I/build/build_docker/base/base/.. -I/build/contrib/cctz/include -I/build/contrib/re2 -I/build/base/pcg-random/. -I/build/contrib/libfiu/libfiu -I/build/contrib/libssh/include -I/build/build_docker/contrib/libssh/include -I/build/contrib/miniselect/include -I/build/contrib/zstd/lib -I/build/contrib/pocketfft -I/build/contrib/lz4/lib -I/build/contrib/libarchive-cmake -I/build/contrib/libarchive/libarchive -I/build/contrib/minizip-ng -I/build/contrib/minizip-ng-cmake -isystem /build/contrib/llvm-project/libcxx/include -isystem /build/contrib/llvm-project/libcxxabi/include -isystem /build/contrib/libunwind/include -isystem /build/contrib/jemalloc-cmake/include -isystem /build/contrib/sparsehash-c11 -isystem /build/contrib/incbin -isystem /build/contrib/cityhash102/include -isystem /build/contrib/boost -isystem /build/base/poco/Net/include -isystem /build/base/poco/Foundation/include -isystem /build/base/poco/NetSSL_OpenSSL/include -isystem /build/base/poco/Crypto/include -isystem /build/contrib/openssl-cmake/linux_x86_64/include -isystem /build/contrib/openssl/include -isystem /build/base/poco/Util/include -isystem /build/base/poco/JSON/include -isystem /build/base/poco/XML/include -isystem /build/contrib/replxx/include -isystem /build/contrib/fmtlib-cmake/../fmtlib/include -isystem /build/contrib/magic_enum/include -isystem /build/contrib/double-conversion -isystem /build/contrib/dragonbox/include -isystem /build/contrib/libdivide-cmake/. -isystem /build/contrib/libdivide -isystem /build/contrib/zlib-ng -isystem /build/build_docker/contrib/zlib-ng-cmake -isystem /build/contrib/libcpuid -isystem /build/contrib/abseil-cpp -isystem /build/contrib/pdqsort -isystem /build/contrib/xz/src/liblzma/api -isystem /build/contrib/c-ares/src/lib -isystem /build/contrib/c-ares/include -isystem /build/contrib/c-ares-cmake/linux -isystem /build/contrib/aws/src/aws-cpp-sdk-core/include -isystem /build/build_docker/contrib/aws-cmake/include -isystem /build/contrib/aws/generated/src/aws-cpp-sdk-s3/include -isystem /build/contrib/aws-c-auth/include -isystem /build/contrib/aws-c-common/include -isystem /build/contrib/aws-c-io/include -isystem /build/contrib/aws-crt-cpp/include -isystem /build/contrib/aws-c-mqtt/include -isystem /build/contrib/aws-c-sdkutils/include -isystem /build/contrib/azure/sdk/core/azure-core/inc -isystem /build/contrib/azure/sdk/identity/azure-identity/inc -isystem /build/contrib/azure/sdk/storage/azure-storage-common/inc -isystem /build/contrib/azure/sdk/storage/azure-storage-blobs/inc -isystem /build/contrib/brotli/c/include -isystem /build/contrib/snappy -isystem /build/build_docker/contrib/snappy-cmake -isystem /build/contrib/libbcrypt -isystem /build/contrib/msgpack-c/include -isystem /build/build_docker/contrib/liburing/src/include-compat -isystem /build/build_docker/contrib/liburing/src/include -isystem /build/contrib/liburing/src/include -isystem /build/contrib/fast_float/include -isystem /build/contrib/QAT-ZSTD-Plugin/src -isystem /build/contrib/bzip2 -isystem /build/build_docker/contrib/bzip2 --gcc-toolchain=/build/cmake/linux/../../contrib/sysroot/linux-x86_64 -fdiagnostics-color=always -Xclang -fuse-ctor-homing -Wno-enum-constexpr-conversion -fsized-deallocation  -UNDEBUG -gdwarf-aranges -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -ftime-trace -falign-functions=32 -mbranches-within-32B-boundaries -ffp-contract=off  -fdiagnostics-absolute-paths -fstrict-vtable-pointers -Wall -Wextra -Weverything -Wpedantic -Wno-zero-length-array -Wno-c++98-compat-pedantic -Wno-c++98-compat -Wno-c++20-compat -Wno-sign-conversion -Wno-implicit-int-conversion -Wno-implicit-int-float-conversion -Wno-ctad-maybe-unsupported -Wno-disabled-macro-expansion -Wno-documentation-unknown-command -Wno-double-promotion -Wno-exit-time-destructors -Wno-float-equal -Wno-global-constructors -Wno-missing-prototypes -Wno-missing-variable-declarations -Wno-padded -Wno-switch-enum -Wno-undefined-func-template -Wno-unused-template -Wno-vla -Wno-weak-template-vtables -Wno-weak-vtables -Wno-thread-safety-negative -Wno-enum-constexpr-conversion -Wno-unsafe-buffer-usage -Wno-switch-default -g -Og -g  -D_LIBCPP_DEBUG=0 -std=c++23   -D OS_LINUX -Werror -Wno-deprecated-declarations -Wno-poison-system-directories -nostdinc++ -MD -MT src/CMakeFiles/clickhouse_common_io.dir/IO/WriteBufferFromS3.cpp.o -MF src/CMakeFiles/clickhouse_common_io.dir/IO/WriteBufferFromS3.cpp.o.d -o src/CMakeFiles/clickhouse_common_io.dir/IO/WriteBufferFromS3.cpp.o -c /build/src/IO/WriteBufferFromS3.cpp
Jul 05 20:32:18 /build/src/IO/BufferWithOwnMemory.h:73:9: error: 1 uninitialized field at the end of the constructor call [clang-analyzer-optin.cplusplus.UninitializedObject,-warnings-as-errors]
Jul 05 20:32:18    73 |         swap(rhs);
Jul 05 20:32:18       |         ^
Jul 05 20:32:18 /build/src/IO/BufferWithOwnMemory.h:47:27: note: uninitialized field 'this->allow_gwp_asan_force_sample'
Jul 05 20:32:18    47 |     [[maybe_unused]] bool allow_gwp_asan_force_sample;
Jul 05 20:32:18       |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:121:9: note: Assuming field 'is_prefinalized' is false
Jul 05 20:32:18   121 |     if (is_prefinalized)
Jul 05 20:32:18       |         ^~~~~~~~~~~~~~~
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:121:5: note: Taking false branch
Jul 05 20:32:18   121 |     if (is_prefinalized)
Jul 05 20:32:18       |     ^
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:136:9: note: Assuming the condition is false
Jul 05 20:32:18   136 |     if (available() > 0)
Jul 05 20:32:18       |         ^~~~~~~~~~~~~~~
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:136:5: note: Taking false branch
Jul 05 20:32:18   136 |     if (available() > 0)
Jul 05 20:32:18       |     ^
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:139:5: note: Calling 'WriteBufferFromS3::detachBuffer'
Jul 05 20:32:18   139 |     detachBuffer();
Jul 05 20:32:18       |     ^~~~~~~~~~~~~~
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:340:14: note: Assuming 'data_size' is equal to field 'hidden_size'
Jul 05 20:32:18   340 |     chassert(data_size == hidden_size);
Jul 05 20:32:18       |              ^
Jul 05 20:32:18 /build/base/base/../base/defines.h:125:48: note: expanded from macro 'chassert'
Jul 05 20:32:18   125 |         #define chassert(...) CHASSERT_INVOKE((__VA_ARGS__, chassert_2, chassert_1))
Jul 05 20:32:18       |                                                ^~~~~~~~~~~
Jul 05 20:32:18 /build/base/base/../base/defines.h:124:58: note: expanded from macro 'CHASSERT_INVOKE'
Jul 05 20:32:18   124 |         #define CHASSERT_INVOKE(tuple) CHASSERT_DISPATCH tuple
Jul 05 20:32:18       |                                                          ^~~~~
Jul 05 20:32:18 /build/base/base/../base/defines.h:123:51: note: expanded from macro 'CHASSERT_DISPATCH'
Jul 05 20:32:18   123 |         #define CHASSERT_DISPATCH(_1,_2, N,...) N(_1, _2)
Jul 05 20:32:18       |                                                   ^~
Jul 05 20:32:18 /build/base/base/../base/defines.h:111:59: note: expanded from macro 'chassert_1'
Jul 05 20:32:18   111 |         #define chassert_1(x, ...) do { static_cast<bool>(x) ? void(0) : ::DB::abortOnFailedAssertion(#x); } while (0)
Jul 05 20:32:18       |                                                           ^
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:340:5: note: '?' condition is true
Jul 05 20:32:18   340 |     chassert(data_size == hidden_size);
Jul 05 20:32:18       |     ^
Jul 05 20:32:18 /build/base/base/../base/defines.h:125:73: note: expanded from macro 'chassert'
Jul 05 20:32:18   125 |         #define chassert(...) CHASSERT_INVOKE((__VA_ARGS__, chassert_2, chassert_1))
Jul 05 20:32:18       |                                                                         ^
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:340:5: note: Loop condition is false.  Exiting loop
Jul 05 20:32:18   340 |     chassert(data_size == hidden_size);
Jul 05 20:32:18       |     ^
Jul 05 20:32:18 /build/base/base/../base/defines.h:125:73: note: expanded from macro 'chassert'
Jul 05 20:32:18   125 |         #define chassert(...) CHASSERT_INVOKE((__VA_ARGS__, chassert_2, chassert_1))
Jul 05 20:32:18       |                                                                         ^
Jul 05 20:32:18 /build/src/IO/WriteBufferFromS3.cpp:342:16: note: Calling move constructor for 'Memory<Allocator<false, false>>'
Jul 05 20:32:18   342 |     auto buf = std::move(memory);
Jul 05 20:32:18       |                ^~~~~~~~~~~~~~~~~
Jul 05 20:32:18 /build/src/IO/BufferWithOwnMemory.h:73:9: note: 1 uninitialized field at the end of the constructor call
Jul 05 20:32:18    73 |         swap(rhs);
Jul 05 20:32:18       |         ^~~~~~~~~
Jul 05 20:32:18 49017 warnings generated.
Jul 05 20:32:18 Suppressed 49579 warnings (49016 in non-user code, 563 NOLINT).
Jul 05 20:32:18 Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Jul 05 20:32:18 1 warning treated as error

@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Jul 5, 2024

clang-tidy is broken in master, I'll fix

@alesapin alesapin mentioned this pull request Jul 5, 2024
Merged
19 tasks
@azat azat mentioned this pull request Jul 6, 2024
Merged
1 task
@azat
Copy link
Copy Markdown
Member

azat commented Jul 6, 2024

Wow, green CI! :)

@alesapin alesapin added this pull request to the merge queue Jul 6, 2024
Merged via the queue into master with commit bb92716 Jul 6, 2024
@alesapin alesapin deleted the pin_python_packages branch July 6, 2024 10:29
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 6, 2024
@azat azat mentioned this pull request Jul 8, 2024
Merged
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

Assignees

No one assigned

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sanitizers builds are broken

6 participants

@alesapin @robot-ch-test-poll3 @azat @robot-ch-test-poll @robot-clickhouse-ci-2 @robot-clickhouse