Skip to content

tests: fix 01563_distributed_query_finish flakiness (due to system.*_log_sender)#66171

Merged
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
azat:tests/01563_distributed_query_finish
Jul 6, 2024
Merged

tests: fix 01563_distributed_query_finish flakiness (due to system.*_log_sender)#66171
nikitamikhaylov merged 1 commit intoClickHouse:masterfrom
azat:tests/01563_distributed_query_finish

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 6, 2024

From CI logs 1, during this test was executing on server:

2024.07.05 19:29:45.856853 [ 1328 ] {} <Error> system.zookeeper_log_sender.DistributedInsertQueue.default: Code: 210. DB::NetException: Connection reset by peer, while writing to socket (172.17.0.2:38546 -> 3.16.142.177:9440): While sending /var/lib/clickhouse/store/aa8/aa8f6e66-486b-4dc3-85a1-4941e69cb99f/shard1_replica1/447.bin. (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):

So let's add retries

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: Stateless tests

…log_sender)

From CI logs [1], during this test was executing on server:

    2024.07.05 19:29:45.856853 [ 1328 ] {} <Error> system.zookeeper_log_sender.DistributedInsertQueue.default: Code: 210. DB::NetException: Connection reset by peer, while writing to socket (172.17.0.2:38546 -> 3.16.142.177:9440): While sending /var/lib/clickhouse/store/aa8/aa8f6e66-486b-4dc3-85a1-4941e69cb99f/shard1_replica1/447.bin. (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/66162/daae5d4d4661c780b6368950ec484415ca3a0492/stateless_tests__aarch64_.html

So let's add retries

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 6, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jul 6, 2024

This is an automated comment for commit ffd6bf2 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@nikitamikhaylov nikitamikhaylov self-assigned this Jul 6, 2024
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Jul 6, 2024
Merged via the queue into ClickHouse:master with commit ed70bc8 Jul 6, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 6, 2024
@azat azat deleted the tests/01563_distributed_query_finish branch July 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants