Revert "Revert "Fix AWS ECS"" by Avogar · Pull Request #65362 · ClickHouse/ClickHouse

Avogar · 2024-06-17T21:43:14Z

robot-clickhouse-ci-2 · 2024-06-17T21:45:06Z

This is an automated comment for commit fd8c992 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Algunenano · 2024-06-18T10:11:17Z

Keep in mind that https://s3.amazonaws.com/clickhouse-test-reports/0/a29babcb611411ff7ee4edbbd4135ca0d1e45280/stateless_tests__tsan__s3_storage__[1_5].html was probably related to this PR before it was reverted (data race in CH local)

Avogar · 2024-06-18T10:19:00Z

@alexey-milovidov can you check the data race in your test?

alexey-milovidov · 2024-06-18T10:28:04Z

Looks like a bug in AWS SDK (the second one in a row). I will take a look.

alexey-milovidov · 2024-06-23T17:45:11Z

aws/aws-sdk-cpp#3013

Sharu95 · 2024-06-26T11:22:50Z

Man things are moving fast in these PRs, appreciate the effort and pace here 🚀 Also saw the cpp PR was merged in aws/aws-sdk-cpp#3013 💎

Sharu95 · 2024-07-01T10:06:36Z

Was just wondering if there were any updates on this? 😄

alexey-milovidov · 2024-07-02T02:21:54Z

It is in progress, I am doing it in between of other pull requests.
Hold tight :)

jakedaleweb · 2024-07-11T21:12:24Z

Hello 👋 how's this coming along? anything we can do to help?

alexey-milovidov · 2024-07-11T21:58:36Z

@jakedaleweb, There were no updates past week.
Have a good day. Cheers, Alexey.

jakedaleweb · 2024-07-11T23:43:32Z

@alexey-milovidov thanks for the update, I really appreciate your communication on this PR.

Is this blocked by another PR on a project somewhere else? Or is is a matter of finding time to work on it?

Apologies if I am coming off as pushy, but getting this working is make-or-break for my implementation of Clickhouse which I am really keen to keep moving on.

jakedaleweb · 2024-08-01T04:30:12Z

Hi, just trying to get a pulse on this one as it will inform the route I take for my work. Is there likely to be a resolution on this in days, weeks, months?

Again, not trying to be pushy! 😅

jakedaleweb · 2024-08-15T03:35:04Z

FYI have managed to work around this #33771 (comment)

Sharu95 · 2024-08-29T12:06:43Z

@alexey-milovidov, any deployed releases with this fix? 😄

alexey-milovidov · 2024-08-29T14:06:08Z

The release builds are ready:

curl https://clickhouse.com/ | sh

Sharu95 · 2024-08-30T10:19:50Z

Thanks @alexey-milovidov! I was using the Docker server version, it works with the head tag, but experienced the same problems with 24.7.4.51. When I did the curl, it seems like the version was different, so I assume its just the docker release that is different

alexey-milovidov · 2024-08-30T11:44:32Z

It is from 24.9 (which is currently in pre-release).

…rt-65164-ecs Revert "Revert "Fix AWS ECS""

…14/65362 24.8.14 Stable backport of ClickHouse#65362: Revert "Revert "Fix AWS ECS""

…rt-65164-ecs Revert "Revert "Fix AWS ECS""

Revert "Revert "Fix AWS ECS""

4817657

robot-clickhouse-ci-2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jun 17, 2024

Merge branch 'master' into revert-65361-revert-65164-ecs

da299ac

Avogar mentioned this pull request Jun 20, 2024

Fix AWS ECS #65164

Merged

19 tasks

alexey-milovidov self-assigned this Jun 23, 2024

Merge branch 'master' into revert-65361-revert-65164-ecs

b6945bd

This was referenced Jun 23, 2024

Fix TSan report around condvar in HostResolver ClickHouse/aws-sdk-cpp#25

Merged

Fix TSan report around condvar in host resolver aws/aws-sdk-cpp#3013

Merged

alexey-milovidov added 7 commits June 23, 2024 19:46

Update submodule

e0ef262

Fix error

9948150

Merge branch 'ecs' into revert-65361-revert-65164-ecs

1e19732

Merge branch 'master' into ecs

9c9e16d

Update submodule

3b377fa

Update submodule

49634db

Merge branch 'ecs' into revert-65361-revert-65164-ecs

0b62ad5

vjeranc mentioned this pull request Jul 22, 2024

Segmentation Fault in ClickHouse 24.6.2.17 with Concurrent Queries on AWS ECS Using Official ARM64 Docker Image #66891

Closed

alexey-milovidov added 4 commits August 18, 2024 06:19

Merge branch 'master' into revert-65361-revert-65164-ecs

487c6a0

Fix error

03ab872

Fix error

4e91c66

Merge branch 'master' into revert-65361-revert-65164-ecs

fd8c992

alexey-milovidov merged commit 732008f into master Aug 19, 2024

alexey-milovidov deleted the revert-65361-revert-65164-ecs branch August 19, 2024 09:27

robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 19, 2024

yokofly mentioned this pull request Oct 16, 2025

avoid AWS ECS crash (#10829) timeplus-io/proton#990

Merged

4 tasks

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 25, 2026

Merge pull request ClickHouse#65362 from ClickHouse/revert-65361-reve…

04f28d9

…rt-65164-ecs Revert "Revert "Fix AWS ECS""

zvonand mentioned this pull request Feb 25, 2026

24.8.14 Stable backport of #65362: Revert "Revert "Fix AWS ECS"" Altinity/ClickHouse#1449

Merged

25 tasks

zvonand added a commit to Altinity/ClickHouse that referenced this pull request Feb 26, 2026

Merge pull request #1449 from Altinity/backports/customizations/24.8.…

2a0639f

…14/65362 24.8.14 Stable backport of ClickHouse#65362: Revert "Revert "Fix AWS ECS""

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 17, 2026

Merge pull request ClickHouse#65362 from ClickHouse/revert-65361-reve…

9994737

…rt-65164-ecs Revert "Revert "Fix AWS ECS""

zvonand mentioned this pull request Mar 17, 2026

24.8.14 Stable Pre-Release PR Altinity/ClickHouse#1540

Merged

Conversation

Avogar commented Jun 17, 2024

Uh oh!

robot-clickhouse-ci-2 commented Jun 17, 2024 • edited by robot-ch-test-poll3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Algunenano commented Jun 18, 2024

Uh oh!

Avogar commented Jun 18, 2024

Uh oh!

alexey-milovidov commented Jun 18, 2024

Uh oh!

alexey-milovidov commented Jun 23, 2024

Uh oh!

Sharu95 commented Jun 26, 2024

Uh oh!

Sharu95 commented Jul 1, 2024

Uh oh!

alexey-milovidov commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakedaleweb commented Jul 11, 2024

Uh oh!

alexey-milovidov commented Jul 11, 2024

Uh oh!

jakedaleweb commented Jul 11, 2024

Uh oh!

jakedaleweb commented Aug 1, 2024

Uh oh!

jakedaleweb commented Aug 15, 2024

Uh oh!

Sharu95 commented Aug 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Aug 29, 2024

Uh oh!

Sharu95 commented Aug 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

robot-clickhouse-ci-2 commented Jun 17, 2024 •

edited by robot-ch-test-poll3

Loading

alexey-milovidov commented Jul 2, 2024 •

edited

Loading

Sharu95 commented Aug 29, 2024 •

edited

Loading

Sharu95 commented Aug 30, 2024 •

edited

Loading