Fix TSan report around condvar in host resolver#3013
Merged
SergeyRyabinin merged 2 commits intoaws:mainfrom Jun 24, 2024
Merged
Fix TSan report around condvar in host resolver#3013SergeyRyabinin merged 2 commits intoaws:mainfrom
SergeyRyabinin merged 2 commits intoaws:mainfrom
Conversation
| else | ||
| { | ||
| std::unique_lock<std::mutex> lock(hostResolverMutex); | ||
| hostResolverCV.notify_one(); |
Contributor
There was a problem hiding this comment.
wait
CV should be still notified in success case
otherwise there might be a rare race condition issue
when on the main thread,
if (!hostResolved) {
is not resolved and goes into if branch
but then before hitting the the line, it get resolved
hostResolverCV.wait_for(lock, std::chrono::milliseconds(1000));
resulting in an unnecessary 1s wait (which is here just to avoid infinite wait in case of any other issues to be honest).
Contributor
Author
There was a problem hiding this comment.
Ok, added it.
Contributor
There was a problem hiding this comment.
perfect, thank you, will merge soon!
SergeyRyabinin
approved these changes
Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The issue was found by the ClickHouse continuous integration system here: ClickHouse/ClickHouse#65362
This change fixes the following TSan report:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.