Skip to content

Fix initialization order (ServerUUID/ZooKeeper)#64986

Merged
tavplubix merged 5 commits intomasterfrom
fix_init_order
Jun 14, 2024
Merged

Fix initialization order (ServerUUID/ZooKeeper)#64986
tavplubix merged 5 commits intomasterfrom
fix_init_order

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Jun 7, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed Session moved to another server error from [Zoo]Keeper that might happen after server startup when the config has includes from [Zoo]Keeper

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with Aarch64
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@tavplubix tavplubix mentioned this pull request Jun 7, 2024
Closed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 7, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jun 7, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 82a5496 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckChecks correctness of the PR's body✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@antonio2368 antonio2368 self-assigned this Jun 7, 2024
@tavplubix tavplubix added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit bc8c8ff Jun 14, 2024
@tavplubix tavplubix deleted the fix_init_order branch June 14, 2024 13:00
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 14, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#64986
e09c4b5
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix UT due to ClickHouse/ClickHouse#64986
014864c
baibaichen added a commit to apache/gluten that referenced this pull request Jun 16, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616) (#6100)
a08a57c 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616)

* Fix Build due to ClickHouse/ClickHouse#64412

* Fix UT due to ClickHouse/ClickHouse#64986

* Fix build due to ClickHouse/ClickHouse#60556

* Ignore TPCH Q17 which include avg

* Fix 'Invalid Field get from type Decimal64 to type Int64' in debug build.

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@alesapin alesapin added pr-must-backport-cloud and removed pr-synced-to-cloud The PR is synced to the cloud repo labels Jun 17, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tavplubix @robot-ch-test-poll3 @antonio2368 @alesapin @robot-ch-test-poll @robot-ch-test-poll1