Skip to content

Refactor s3 settings (move settings parsing into single place)#64412

Merged
kssenii merged 27 commits intomasterfrom
unite-storages3-and-disks3-settings
Jun 14, 2024
Merged

Refactor s3 settings (move settings parsing into single place)#64412
kssenii merged 27 commits intomasterfrom
unite-storages3-and-disks3-settings

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented May 26, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

  • Allow: Integration Tests
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Unit tests
  • Allow: Performance tests
  • Allow: All with aarch64
  • Allow: All with ASAN
  • Allow: All with TSAN
  • Allow: All with Analyzer
  • Allow: All with Azure
  • Allow: Add your option here
  • Exclude: Fast test
  • Exclude: Integration Tests
  • Exclude: Stateless tests
  • Exclude: Stateful tests
  • Exclude: Performance tests
  • Exclude: All with ASAN
  • Exclude: All with TSAN
  • Exclude: All with MSAN
  • Exclude: All with UBSAN
  • Exclude: All with Coverage
  • Exclude: All with Aarch64
  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)
  • allow: batch 1 for multi-batch jobs
  • allow: batch 2
  • allow: batch 3
  • allow: batch 4, 5 and 6

This was partially already done by #59767, but not fully.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 26, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented May 26, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit ef8810a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help⏳ pending
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
PR CheckChecks correctness of the PR's body✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from a504622 to 9a875f9 Compare May 26, 2024 11:43
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from 9a875f9 to 80f195d Compare May 27, 2024 10:11
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from 043e41d to fd31f8e Compare May 27, 2024 16:10
@CheSema CheSema self-assigned this May 27, 2024
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from fd31f8e to 56c7301 Compare May 27, 2024 16:28
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from f9ea6ee to 73e9719 Compare May 28, 2024 10:52
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from 6e8ac6b to f85030f Compare May 29, 2024 10:35
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from f366f29 to 779eaa0 Compare May 31, 2024 15:53
@kssenii kssenii force-pushed the unite-storages3-and-disks3-settings branch from 575fa55 to a035e4e Compare June 3, 2024 09:59
@kssenii kssenii marked this pull request as ready for review June 3, 2024 16:17
@kssenii kssenii requested a review from CheSema June 4, 2024 13:55
CheSema
CheSema reviewed Jun 7, 2024
View reviewed changes
src/IO/S3Common.h
struct ProxyConfigurationResolver;

HTTPHeaderEntries getHTTPHeaders(const std::string & config_elem, const Poco::Util::AbstractConfiguration & config);
namespace S3
Copy link
Copy Markdown
Member

@CheSema CheSema Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy to see this structured lists. Huge thank to you!

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Jun 14, 2024

AST fuzzer (debug)

#65055

Integration tests (aarch64) [5/6] — fail: 1

test_checking_s3_blobs_paranoid/test.py::test_query_is_canceled_with_inf_retries - fails for a while now in all PRs

Stateless tests (debug) [4/5] — fail: 1

00626_replace_partition_from_table_zookeeper -- not related to changes

@kssenii kssenii added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit 321f62d Jun 14, 2024
@kssenii kssenii deleted the unite-storages3-and-disks3-settings branch June 14, 2024 13:25
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 14, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#64412
8519ffb
baibaichen added a commit to Kyligence/gluten that referenced this pull request Jun 15, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#64412
a306bdc
baibaichen added a commit to apache/gluten that referenced this pull request Jun 16, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616) (#6100)
a08a57c 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240616)

* Fix Build due to ClickHouse/ClickHouse#64412

* Fix UT due to ClickHouse/ClickHouse#64986

* Fix build due to ClickHouse/ClickHouse#60556

* Ignore TPCH Q17 which include avg

* Fix 'Invalid Field get from type Decimal64 to type Int64' in debug build.

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Algunenano
Algunenano reviewed Oct 24, 2024
View reviewed changes
src/IO/S3Common.cpp

if (from.no_sign_request.has_value())
no_sign_request = from.no_sign_request;
size_t max_get_burst = isChanged("max_get_burts") ? get("max_get_burst").get<UInt64>() : default_max_get_burst;
Copy link
Copy Markdown
Member

@Algunenano Algunenano Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the typos while refactoring this (max_get_burts -> max_get_burst, max_put_burts -> max_put_burst).

Aside from the typos, I don't quite see how this is supposed to work. Who could populate RequestSettings::max_get_burts considering the setting is not declared inside this class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@CheSema CheSema CheSema approved these changes

Assignees

@CheSema CheSema

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kssenii @robot-ch-test-poll2 @Algunenano @CheSema @robot-clickhouse