Skip to content

Follow up to #56541#57141

Merged
kssenii merged 3 commits intomasterfrom
remove-test-case
Nov 24, 2023
Merged

Follow up to #56541#57141
kssenii merged 3 commits intomasterfrom
remove-test-case

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Nov 23, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Closes #56798.

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 23, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Nov 23, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit ff3224e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Nov 23, 2023

Does this fail to boot because the order in which things are start up or something else completely? Because the query does work in the tests, it's just that the table can't be attached after reboot. Maybe the collection should be available before the table is attached?

@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Nov 23, 2023 •
edited
Loading

Maybe the collection should be available before the table is attached?

yeah, for some reason I thought it is not doable for named collections created from sql, forgot how it was impemented...
Now I remembered, pushed the fix.

@kssenii kssenii requested a review from Algunenano November 23, 2023 12:23
@kssenii kssenii changed the title Update 02908_filesystem_cache_as_collection.sql Follow up to #56541 Nov 23, 2023
@Algunenano Algunenano self-assigned this Nov 23, 2023
Algunenano
Algunenano approved these changes Nov 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server boots now 👍

@Algunenano Algunenano mentioned this pull request Nov 23, 2023
Closed
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Nov 24, 2023

Integration tests

test_dictionaries_postgresql/test.py::test_postgres_schema
test_system_clusters_actual_information/test.py::test

@kssenii kssenii merged commit 650c1e9 into master Nov 24, 2023
@kssenii kssenii deleted the remove-test-case branch November 24, 2023 10:45
@kssenii kssenii mentioned this pull request Jun 11, 2024
Closed
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 11, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jun 11, 2024
@robot-clickhouse
Backport #57141 to 23.8: Follow up to #56541
e674712
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 11, 2024
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 11, 2024
kssenii added a commit that referenced this pull request Jun 24, 2024
@kssenii
Merge pull request #65080 from ClickHouse/backport/23.8/57141
185ae73 
Backport #57141 to 23.8: Follow up to #56541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stress tests: exit 1 in run_with_retry exits from the whole check

5 participants

@kssenii @robot-ch-test-poll @Algunenano @alexey-milovidov @robot-ch-test-poll4