Skip to content

Cache configuration improvement#56541

Merged
kssenii merged 6 commits intomasterfrom
cache-config-improvement
Nov 14, 2023
Merged

Cache configuration improvement#56541
kssenii merged 6 commits intomasterfrom
cache-config-improvement

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Nov 9, 2023 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow getting cache configuration from 'named_collection' section in config or from sql created named collection.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-improvement Pull request with some product improvements label Nov 9, 2023
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 9, 2023 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit e428e4e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@kssenii kssenii force-pushed the cache-config-improvement branch from 6bcc7c0 to 6f72f41 Compare November 9, 2023 17:36
@kssenii kssenii force-pushed the cache-config-improvement branch from 6f72f41 to c28c1ac Compare November 9, 2023 17:39
@antonio2368 antonio2368 self-assigned this Nov 10, 2023
antonio2368
antonio2368 reviewed Nov 10, 2023
View reviewed changes
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Nov 14, 2023

Integration tests (release) [4/4] — fail: 1, passed: 648

test_delayed_replica_failover/test.py::test

Stateless tests (debug, s3 storage) [3/6] — fail: 1, passed: 936, skipped: 18

01280_ttl_where_group_by

Stateless tests (release, analyzer) — fail: 1, passed: 5817, skipped: 13

02404_memory_bound_merging

@kssenii kssenii merged commit 905b75b into master Nov 14, 2023
@kssenii kssenii deleted the cache-config-improvement branch November 14, 2023 12:03
@tavplubix tavplubix mentioned this pull request Nov 15, 2023
Closed
robot-clickhouse added a commit that referenced this pull request Jun 11, 2024
@robot-clickhouse
Backport #57141 to 23.8: Follow up to #56541
e674712
kssenii added a commit that referenced this pull request Jun 24, 2024
@kssenii
Merge pull request #65080 from ClickHouse/backport/23.8/57141
185ae73 
Backport #57141 to 23.8: Follow up to #56541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kssenii @robot-ch-test-poll4 @antonio2368