Skip to content

Function "netloc": fix wrong code.#13446

Merged
alexey-milovidov merged 5 commits intomasterfrom
fix-netloc
Aug 8, 2020
Merged

Function "netloc": fix wrong code.#13446
alexey-milovidov merged 5 commits intomasterfrom
fix-netloc

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong code in function netloc. This fixes #13335.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 7, 2020
@qoega
Copy link
Copy Markdown
Member

qoega commented Aug 7, 2020

There should be no schema in netloc
https://stackoverflow.com/a/53993037
https://tools.ietf.org/html/rfc1808.html#ref-2

SELECT netloc('http://paul@www.example.com:80/') AS Netloc;
2020-08-07 05:03:43 -paul@www.example.com:80
2020-08-07 05:03:43 +http://paul@www.example.com:80

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Query Fuzzer - it's about #13283

@alexey-milovidov alexey-milovidov merged commit ba5988d into master Aug 8, 2020
@alexey-milovidov alexey-milovidov deleted the fix-netloc branch August 8, 2020 22:39
@alexey-milovidov alexey-milovidov self-assigned this Aug 8, 2020
alexey-milovidov added a commit that referenced this pull request Aug 15, 2020
Backport #13446 to 20.7: Function "netloc": fix wrong code.
alexey-milovidov added a commit that referenced this pull request Aug 20, 2020
Backport #13446 to 20.6: Function "netloc": fix wrong code.
alexey-milovidov added a commit that referenced this pull request Aug 20, 2020
Backport #13446 to 20.5: Function "netloc": fix wrong code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

netloc: std::length_error

3 participants