Conversation
+ some cosmetic changes
programs/client/QueryFuzzer.cpp
Outdated
| // Don't fuzz it. It is a somewhat unconventional AST which does not | ||
| // directly correspond to the query text, but performs some validation | ||
| // by itself. It considers its children to be ASTLiteral * only, so when | ||
| // we replace them with something column-like, the client segfaults. |
Member
There was a problem hiding this comment.
But it should not crash, why don't just throw exception about wrong AST?
Contributor
Author
There was a problem hiding this comment.
That is the problem -- the AST is validated at the parsing stage, so if you change it after that, you get a segfault. It is not possible to trigger from SQL. Normally we keep the AST close to what is written, and validate it later -- this is the only case I encountered so far that doesn't work like this.
Member
There was a problem hiding this comment.
Why don't add yet another validation even if it is not needed at all in normal runs?
alexey-milovidov
approved these changes
Aug 3, 2020
Contributor
Author
|
Contributor
Author
|
So what I did eventually is:
I'll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):