add scroll to the setting drawer#168
add scroll to the setting drawer#168alxlion merged 1 commit intoClaperCo:devfrom ChayanDass:fix/setting_drawer
Conversation
|
@mahtaran , could you please take a look on this? |
mahtaran
left a comment
There was a problem hiding this comment.
I don't have the environment to test these changes locally, but the code and the screencast looks good! What I will say is that the diff is a bit larger than it needs to be, should be majorly resolved if you do a formatter pass (mix format)
|
|
||
| ~H""" | ||
| <div class="grid grid-cols-1 @md:grid-cols-2 @md:space-x-5 px-5 py-3"> | ||
| <div class="grid grid-cols-1 @md:grid-cols-2 @md:space-x-5 px-5 py-3 h-full mb-10 "> |
There was a problem hiding this comment.
| <div class="grid grid-cols-1 @md:grid-cols-2 @md:space-x-5 px-5 py-3 h-full mb-10 "> | |
| <div class="grid grid-cols-1 @md:grid-cols-2 @md:space-x-5 px-5 py-3 h-full mb-10"> |
You added a trailing space here ^^
There was a problem hiding this comment.
I have run mix format, can you check it again , thank you !
There was a problem hiding this comment.
Those diffs only appear in GitHub, but in VS Code, it's showing only 6-8 line changes
There was a problem hiding this comment.
Yeah, that makes sense, seeing as the indenting has changed. You can toggle that setting in GitHub to minimise such changes
Signed-off-by: Chayan Das <01chayandas@gmail.com>
|
Thanks for the reminder @ChayanDass and sorry for the delay! I'll take a look at it today and merge it. |
##⚠️ Breaking changes - S3 variables are now named: S3_ACCESS_KEY_ID, S3_SECRET_ACCESS_KEY, S3_REGION and S3_BUCKET - Users now have roles. Refer to the `roles` table and assign a role to a user with the `role_id` column in the `users` table. ## Features - Add Admin Panel to manage users and presentations - Add user roles: user, admin - Add `LANGUAGES` setting to configure available languages in the app - Add hideable presenter attendee count (#183 #155) - Add Hungarian translation (#161) - Add Latvian translation (#163) - Add custom S3 endpoint with `S3_SCHEME`, `S3_HOST`, `S3_PORT` and `S3_PUBLIC_URL` ## Fixes and improvements - Upgrade JS dependencies - Upgrade Elixir dependencies, including Phoenix Live View to 1.0.17 - Upgrade to Tailwind 4+ - Refactor view templates to use {} instead of <%= %> - Fix event name validation to be required - Docker image is now using Ubuntu instead of Alpine for better dependencies support - Fix scrollbar not showing in event manager when no presentation file (#164) (@aryel780) - Fix settings scroll for small screen (#168) - Fix duplicate key quiz when duplicate (#182) - Fix email change confirmation (#172) - Fix italian translation (#179) - Fix random poll choices (#184)
/claim #146
closes #146
Screencast.from.2025-07-31.14-02-51.webm