[CR] Waterbutler OneDrive Plugin#177
Closed
alexandr-melnikov-dev-pro wants to merge 106 commits intoCenterForOpenScience:developfrom
Closed
[CR] Waterbutler OneDrive Plugin#177alexandr-melnikov-dev-pro wants to merge 106 commits intoCenterForOpenScience:developfrom
alexandr-melnikov-dev-pro wants to merge 106 commits intoCenterForOpenScience:developfrom
Conversation
…displays the folder as a child folder
…e does not have revisions
…. http://localhost:7777/...)
…orks with a single file in the project root folder; todo: test upload to subfolder
…Related: [#OSF-5226]
…gin and fix upload issues
Author
|
Ready for review. |
Member
|
Hey @alexandr-melnikov-dev-pro, This looks really good! I've got some other tasks that I have to finish up first, so it'll be a few weeks before I can review this properly. But from a quick skim-through, it looks solid and I really like some of the refactoring you've done. Thanks for your work on this! Cheers, |
Member
|
Closing this for now, in favor of #205. 205 backs out the write support, so I've archived the work done here in https://github.com/CenterForOpenScience/waterbutler/tree/feature/onedrive-rw for when it is added back in. |
felliott
added a commit
that referenced
this pull request
Nov 13, 2017
This feature was done as a COS-funded Integration Grant by: * Ryan Casey (@caseyrygt) Additional work was done on read-write support by Alexandr Melnikov (@alexandr-melnikov-dev-pro). Read-write will be added in a future release. Thank you both for all your hard work on this! [SVCS-269] [SVCS-458] Closes: #205 Related: #102, #151, #177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request to CenterForOpenScience/osf.io#6589
Previous pull request #151
What was done: