Skip to content

[CR] Waterbutler OneDrive Plugin#151

Closed
caseyrygt wants to merge 95 commits intoCenterForOpenScience:developfrom
caseyrygt:feature/onedrive-provider-35
Closed

[CR] Waterbutler OneDrive Plugin#151
caseyrygt wants to merge 95 commits intoCenterForOpenScience:developfrom
caseyrygt:feature/onedrive-provider-35

Conversation

@caseyrygt
Copy link
Contributor

@caseyrygt caseyrygt commented May 18, 2016

@felliott: This is ready for you to review.

Could you please review the copy functionality? OneDrive's "Copy" function is asynchronous (the other methods are not) and requires the client to check the status of the copy job in order to know when it has completed. If there's a better way than a for loop to check the OneDrive job status, please let me know.

Thanks!

@caseyrygt
added onedrive provider -- copied from Dropbox
205a75d
@caseyrygt
added logging
740e052
@caseyrygt
return onedrive metadata; todo: fix issue where waterbutler thinks a …
c9c76d1 
…folder is a file
@caseyrygt
added todo note
b568b75
@caseyrygt
fixed issue where file was being called instead of folder; todo: OSF …
cb9de83 
…displays the folder as a child folder
@caseyrygt
list children of item in metadata call; file list for folder is now a…
e16c0bd 
…ppearing in OSF
@caseyrygt
fixed mimetype to pull from onedrive mimetype
4c43ac0
@caseyrygt
fixed file display for title at least; todo: fix link not valid error
a8a502c
@caseyrygt
disabled revisions until determining how to handle this since onedriv…
8535b2f 
…e does not have revisions
@caseyrygt
file downloads to browser when directly connected to waterbutler (e.g…
1f271ef 
…. http://localhost:7777/...)
@caseyrygt
delete functionality; tested with file
228a1b3
@caseyrygt
metadata: returns 400 as well when new file does not exist; upload: w…
d476db6 
…orks with a single file in the project root folder; todo: test upload to subfolder
@caseyrygt
handled sub-folder navigation
8934dae
@caseyrygt
cleaned up debugging code
5632357
@caseyrygt
return revision list
2681d24
@caseyrygt
added method to get json revision data since two methods need it
49113db
@caseyrygt
implemented download via past revision
bc28115
@caseyrygt
note on onedrive version limitations.
6cdec71
@caseyrygt
implemented create folder
2bfa5d2
@caseyrygt
fixed issue with having osf onedrive folder set to onedrive root retu…
aa2a08d 
…rned api error
@caseyrygt
fixed issue with uploading to sub folder
8eb2c1c
@caseyrygt
fixed issue with uploading to sub folder
834d188
@caseyrygt
fix invoke test messages
038a18d
@caseyrygt
implementation of copy functionality: in progress pending async issue
407c00b
@caseyrygt
clean up of invoke tests output
2aac59c
@caseyrygt
clean up of invoke tests output
e261ecb
@caseyrygt
Merge remote-tracking branch 'cos-wb/develop' into feature/onedrive-p…
bcd0b57 
…rovider
@caseyrygt
Merge remote-tracking branch 'cos-wb/develop' into feature/onedrive-p…
d706b5f 
…rovider
@caseyrygt
updated OneDrive for v1: add can_duplicate_names method to providers …
a1b570d 
…Related: [#OSF-5226]
@caseyrygt
implemented delete folder
5079a32
felliott
felliott reviewed Aug 1, 2016
View reviewed changes
waterbutler/providers/onedrive/provider.py Outdated
i = 0
status = None

while (i < settings.ONEDRIVE_COPY_INTERATION_COUNT):
Copy link
Member

@felliott felliott Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: INTERATION => ITERATION. Ditto in settings.py.

felliott
felliott reviewed Aug 12, 2016
View reviewed changes
waterbutler/providers/onedrive/provider.py
names = od_path.file_path(data)
ids = od_path.ids(data)

wb_path = WaterButlerPath(names, _ids=ids, folder=path.endswith('/'))
Copy link
Member

@felliott felliott Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return a OneDrivePath here.

@felliott
Copy link
Member

felliott commented Aug 12, 2016

I think the OneDrivePath code might need a rework. Except for validate_v1_path and validate_path, the path argument to the methods you've implemented should always be an instance of OneDrivePath. It's okay for you to provide OneDrive-specific implementations of WaterButlerPath methods. one_drive_parent_folder should probably be parent and operate on self. I'm not entirely sure but it looks file_path and ids are doing double-duty as constructors and accessors. You might replace them with a _build_from_onedrive_response(self, data) class method that builds a new OneDrivePath object. Then, the accessor functionality of those methods come from the WaterButlerPath.parts. Also, WaterButlerPath has a from_parts class method that lets you build a new path object from an existing objects parts.

@alexandr-melnikov-dev-pro alexandr-melnikov-dev-pro mentioned this pull request Nov 23, 2016
Closed
@felliott felliott mentioned this pull request Aug 29, 2017
Closed
@felliott
Copy link
Member

felliott commented Aug 29, 2017

Closing in favor of #205, which extends the work done in this PR. Thanks, @caseyrygt!

@felliott felliott closed this Aug 29, 2017
felliott added a commit that referenced this pull request Nov 13, 2017
@felliott
Merge branch 'feature/onedrive' into develop
26bf209 
 This feature was done as a COS-funded Integration Grant by:
  * Ryan Casey (@caseyrygt)

 Additional work was done on read-write support by Alexandr Melnikov
 (@alexandr-melnikov-dev-pro).  Read-write will be added in a future
 release.

 Thank you both for all your hard work on this!

 [SVCS-269] [SVCS-458]
 Closes: #205
 Related: #102, #151, #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caseyrygt @felliott @chrisseto