Mesh_2: Fix write_vtu in ASCII#5679
Merged
lrineau merged 2 commits intoCGAL:5.1.x-branchfrom May 18, 2021
Merged
Conversation
Member
|
This will conflict with #5677 |
Member
|
I moved the file + renamed the function using |
Contributor
|
Is this bug still in master ? This PR strongly conflicts with #5677 , as the whole file has been made deprecated |
Member
Author
The patch probably applies to the renamed file in #5677. You can apply it directly in the pull-request. |
Member
Author
Yes, the bug is still in |
lrineau
added a commit
to sloriot/cgal
that referenced
this pull request
May 5, 2021
…II-GF Mesh_2: Fix write_vtu in ASCII
Merged
lrineau
added a commit
to lrineau/cgal
that referenced
this pull request
May 12, 2021
…II-GF Mesh_2: Fix write_vtu in ASCII
Contributor
|
Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.3-Ic-128.shtml |
lrineau
added a commit
that referenced
this pull request
May 18, 2021
Mesh_2: Fix write_vtu in ASCII
lrineau
added a commit
that referenced
this pull request
May 18, 2021
Mesh_2: Fix write_vtu in ASCII
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
write_vtu, from PR #3297 (CGAL-4.14) was buggy withASCII_MODE, because of spurious"in the output file.I found out while trying to debug the experimental NURBS mesher.
Release Management