Stream support: VTP and VTU writing functions by maxGimeno · Pull Request #3297 · CGAL/cgal

maxGimeno · 2018-08-27T14:35:03Z

Summary of Changes

Add functions to write surface meshes, c3t3 and cdt to vtp and vtu format, without using the VTK lib, which avoids having to use intermediary structures.

Release Management

Affected package(s):Mesh_2, Mesh_3
Small feature: https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/2D_and_3D_Mesh_Generation/VTK_output
Pre-approval date: 2018/01/17

sloriot · 2018-08-27T14:37:18Z

I don't see any CMakeLists.txt update (in particular in the Polyhedron demo). Is this expected?

maxGimeno · 2018-08-27T14:43:34Z

Yes. It only affects the writing, so we still need VTK to read the data. Do you want me to add #ifdef directives to filtrate what always work and what needs vtk ? It seems like a good idea nw that you mention it.

sloriot · 2018-08-27T14:48:41Z

If you are no longer using data structure from VTK, I don't see why VTK would be needed at all. So find_package(VTK) could be removed for some plugins.

maxGimeno · 2018-08-27T14:51:51Z

It only affects the writing

We still use vtk structures for reading data, so we still need VTK libs.

lrineau · 2018-08-28T08:18:23Z

The idea is that writing a VTU/VTP file is not too complicated, because we master everything, and we can chose a particular file format, in the set of things allowed by the VTK file format description.

But reading VTU/VTP files is another story: one has to be able to read all possible valid VTU/VTP files. That includes at least a full XML parser, the possibility to decode base64, gzip compression, and maybe other things.

So we will be:

very strict in out export format, writing VTU/VTP file in a specific sub-format, with a code that does not use the VTK libraries,
and we have to be conservative in our import of VTK files, and that requires VTK libraries.

lrineau · 2018-10-02T13:19:58Z

Travis reports a license issue:

=> There are modifications in licenses:
 M Stream_support/package_info/Stream_support/license.txt

https://travis-ci.org/CGAL/cgal/jobs/421126628#L1867

…endencies problems. Also fix vtu writer of VTK_io_plugin for polygon meshes.

lrineau · 2018-10-04T09:32:53Z

https://travis-ci.org/CGAL/cgal/jobs/436537979#L3618

[ 93%] Building CXX object CMakeFiles/Constrained_Delaunay_triangulation_2.dir/Constrained_Delaunay_triangulation_2_autogen/mocs_compilation.cpp.o
/home/travis/build/CGAL/cgal/GraphicsView/demo/Triangulation_2/Constrained_Delaunay_triangulation_2.cpp:25:10: fatal error: 
      'CGAL/IO/vtk_io_2.h' file not found
#include <CGAL/IO/vtk_io_2.h>
         ^
1 error generated.
make[2]: *** [CMakeFiles/Constrained_Delaunay_triangulation_2.dir/Constrained_Delaunay_triangulation_2.cpp.o] Error 1
make[1]: *** [CMakeFiles/Constrained_Delaunay_triangulation_2.dir/all] Error 2
make: *** [all] Error 2

lrineau · 2018-10-05T08:57:21Z

We are close:

.. Checking SPDX license identifier presence in header files...
The following files do not have a SPDX license identifier:
Mesh_2/include/CGAL/IO/vtk_io_2.h
Mesh_3/include/CGAL/IO/vtk_io.h

https://travis-ci.org/CGAL/cgal/jobs/437101040#L1815

lrineau · 2018-10-05T14:55:05Z

.. Checking include directives in GPL header files...
The following files do not have an include directive of the package license header:
Mesh_2/include/CGAL/IO/vtk_io_2.h
Mesh_3/include/CGAL/IO/vtk_io.h

lrineau · 2018-10-08T13:53:42Z

@maxGimeno: why the TODO label?

lrineau · 2018-10-08T13:54:28Z

There seem to be indentation issues in this PR.

maxGimeno · 2019-02-07T09:08:32Z

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-4.14-Ic-116.shtml

…or_vtu-GF Stream support: VTP and VTU writing functions

maxGimeno added 4 commits August 23, 2018 15:24

WIP tests with c3t3 and meshdomain ID

2570c21

vtp in plugin

b29534c

WIP integrate functions.

06db5da

Add function for CDT. and use it in Triangulation_2 demo. Missing Doc

223fa68

maxGimeno added TODO Pkg::Stream_support Work in progress labels Aug 27, 2018

lrineau added this to the 4.14-beta milestone Aug 28, 2018

Move and split vtk_io.h to Mesh_2 and Mesh_3 to avoid license and dep…

49b88e5

…endencies problems. Also fix vtu writer of VTK_io_plugin for polygon meshes.

lrineau added Tests failing Conflicts and removed Conflicts labels Oct 4, 2018

Add missing files

9983287

lrineau removed the Tests failing label Oct 4, 2018

lrineau added the Tests failing label Oct 5, 2018

Add SPDX stuff

0c800d5

lrineau removed the Work in progress label Oct 5, 2018

add license includes

e8cf3f3

lrineau removed the Tests failing label Oct 8, 2018

maxGimeno added Work in progress and removed Ready to be tested Tested Under Testing labels Jan 25, 2019

maxGimeno added 2 commits January 30, 2019 16:55

Fix write_vtu_with_argumetns

ad300da

write_vtu uses write_vtu_with_attributes

6cff52c

MaelRL added Accepted small feature and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. Not yet approved The feature or pull-request has not yet been approved. labels Feb 4, 2019

Fix a warning about unused local type

dc275ec

lrineau force-pushed the Stream_support-Dont_use_vtk_for_vtu-GF branch from d67202f to dc275ec Compare February 4, 2019 14:48

maxGimeno added Under Testing and removed Work in progress labels Feb 5, 2019

Fix output_to_vtu

37cc9b0

maxGimeno added the Tested label Feb 7, 2019

lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 7, 2019

lrineau merged commit 37cc9b0 into CGAL:master Feb 7, 2019

lrineau added a commit that referenced this pull request Feb 7, 2019

Merge pull request #3297 from maxGimeno/Stream_support-Dont_use_vtk_f…

9a03d47

…or_vtu-GF Stream support: VTP and VTU writing functions

lrineau removed Under Testing Ready to be tested rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' labels Feb 7, 2019

lrineau deleted the Stream_support-Dont_use_vtk_for_vtu-GF branch February 7, 2019 12:49

lrineau removed the rm only: release blocker For the release team only: the next release requires this issue/PR to be solved/merge label Feb 7, 2019

lrineau mentioned this pull request Apr 3, 2019

Add test for output_to_vtu #3834

Merged

sloriot added the Merged_in_4.14 label Jun 13, 2019

sloriot added the Merged_in_4.13.2 label Oct 16, 2019

MaelRL removed the Merged_in_4.13.2 label Nov 20, 2019

lrineau added the Merged_in_4.13.2 label Feb 25, 2020

lrineau mentioned this pull request May 5, 2021

Mesh_2: Fix write_vtu in ASCII #5679

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stream support: VTP and VTU writing functions#3297

Stream support: VTP and VTU writing functions#3297
lrineau merged 51 commits intoCGAL:masterfrom
maxGimeno:Stream_support-Dont_use_vtk_for_vtu-GF

maxGimeno commented Aug 27, 2018 •

edited by sloriot

Loading

Uh oh!

sloriot commented Aug 27, 2018

Uh oh!

maxGimeno commented Aug 27, 2018 •

edited

Loading

Uh oh!

sloriot commented Aug 27, 2018 •

edited

Loading

Uh oh!

maxGimeno commented Aug 27, 2018

Uh oh!

lrineau commented Aug 28, 2018

Uh oh!

lrineau commented Oct 2, 2018

Uh oh!

lrineau commented Oct 4, 2018

Uh oh!

lrineau commented Oct 5, 2018

Uh oh!

lrineau commented Oct 5, 2018

Uh oh!

lrineau commented Oct 8, 2018

Uh oh!

lrineau commented Oct 8, 2018

Uh oh!

maxGimeno commented Feb 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

maxGimeno commented Aug 27, 2018 • edited by sloriot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Release Management

Uh oh!

sloriot commented Aug 27, 2018

Uh oh!

maxGimeno commented Aug 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sloriot commented Aug 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxGimeno commented Aug 27, 2018

Uh oh!

lrineau commented Aug 28, 2018

Uh oh!

lrineau commented Oct 2, 2018

Uh oh!

lrineau commented Oct 4, 2018

Uh oh!

lrineau commented Oct 5, 2018

Uh oh!

lrineau commented Oct 5, 2018

Uh oh!

lrineau commented Oct 8, 2018

Uh oh!

lrineau commented Oct 8, 2018

Uh oh!

maxGimeno commented Feb 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

maxGimeno commented Aug 27, 2018 •

edited by sloriot

Loading

maxGimeno commented Aug 27, 2018 •

edited

Loading

sloriot commented Aug 27, 2018 •

edited

Loading