Skip to content

remove old schema and code#68

Merged
ericbuckley merged 11 commits into
mainfrom
feature/63-remove-old-schema
Oct 9, 2024
Merged

remove old schema and code#68
ericbuckley merged 11 commits into
mainfrom
feature/63-remove-old-schema

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Oct 4, 2024

Copy link
Copy Markdown
Collaborator

Description

5000 lines removed 😮

Related Issues

#63

Additional Notes

  • Making SQLite the default database for testing and local_server, now the old code is removed. HOWEVER, we will continue to use postgres in CI
  • Removed assets and migrations related to old schema
  • explicitly added DB adapters (postgres, mysql, microsoft sql server) to pyproject.toml
  • consolidating testing session fixtures by creating a new contextmanager function, get_test_session, in database.py and adding conftest.py to assist with creating reusable testing fixtures
  • removed all recordlinker.linkage code and tests, except for matchers, this was copied to recordlinker.linking.old_matchers (we need to port these methods before we can move them)
  • removed old schema calls from the link-record API endpoint
  • removed pyway helpers from recordlinker.utils
  • renamed test_record_linkage to test_main (as its really just testing the API endpoints in main.py). Rewrote some of the tests to make use of the new client fixture.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.
  • I have notified teammates in the review thread to build awareness.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley self-assigned this Oct 7, 2024
@ericbuckley ericbuckley marked this pull request as ready for review October 7, 2024 16:17
@ericbuckley ericbuckley linked an issue Oct 8, 2024 that may be closed by this pull request

@cbrinson-rise8 cbrinson-rise8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this cleanup!

@ericbuckley ericbuckley merged commit 1a2f7ce into main Oct 9, 2024
@ericbuckley ericbuckley deleted the feature/63-remove-old-schema branch October 9, 2024 18:52
ericbuckley added a commit that referenced this pull request Mar 18, 2025
## Description
Minor clean up to remove some old code in our performance testing suite
that isn't being used.

## Additional Notes
[X-Use-Simple-Link was a header
value](#66) that was used for
performance testing the differences between the phdi codebase and Record
Linker. This was [removed many months
ago](#68) when the phdi code
was removed from the codebase, but we forgot to update the performance
tests.
bamader pushed a commit that referenced this pull request Mar 19, 2025
## Description
Minor clean up to remove some old code in our performance testing suite
that isn't being used.

## Additional Notes
[X-Use-Simple-Link was a header
value](#66) that was used for
performance testing the differences between the phdi codebase and Record
Linker. This was [removed many months
ago](#68) when the phdi code
was removed from the codebase, but we forgot to update the performance
tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

delete old schema code

2 participants