removing the unused SIMPLE_LINK parameter#252
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 33 33
Lines 1731 1731
=======================================
Hits 1693 1693
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-goggins
approved these changes
Mar 17, 2025
bamader
pushed a commit
that referenced
this pull request
Mar 19, 2025
## Description Minor clean up to remove some old code in our performance testing suite that isn't being used. ## Additional Notes [X-Use-Simple-Link was a header value](#66) that was used for performance testing the differences between the phdi codebase and Record Linker. This was [removed many months ago](#68) when the phdi code was removed from the codebase, but we forgot to update the performance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor clean up to remove some old code in our performance testing suite that isn't being used.
Additional Notes
X-Use-Simple-Link was a header value that was used for performance testing the differences between the phdi codebase and Record Linker. This was removed many months ago when the phdi code was removed from the codebase, but we forgot to update the performance tests.
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: