Skip to content

BI-2053-fix - fix scaleName and units bug#342

Closed
mlm483 wants to merge 5 commits intodevelopfrom
bug/BI-2053-fix
Closed

BI-2053-fix - fix scaleName and units bug#342
mlm483 wants to merge 5 commits intodevelopfrom
bug/BI-2053-fix

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Mar 27, 2024

CLOSED - see #343 instead.

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2053

The changes made for BI-2053 only handled the file upload path, this fix is to handle ontology term creation through form submission.

The

Dependencies

Breeding-Insight/bi-web#369

Testing

Please include any details needed for reviewers to test this code

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Mar 27, 2024
@mlm483 mlm483 changed the base branch from bug/BI-2065 to develop March 27, 2024 21:54
@mlm483
Copy link
Contributor Author

mlm483 commented Mar 27, 2024

Closing, I'll open a new PR against release/0.9.

@mlm483 mlm483 closed this Mar 27, 2024
@mlm483 mlm483 deleted the bug/BI-2053-fix branch March 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants