BI-2053-fix - Fixed Trait Form Scale Units Handling#369
Merged
Conversation
7 tasks
6 tasks
dmeidlin
approved these changes
Apr 2, 2024
Contributor
|
Developer test passed (see Test Plan) |
davedrp
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-2053
The NumericalTraitForm was sending the "units" input as "scaleName". I fixed this. It should have been done along with Breeding-Insight/bi-api#331, but I missed this workflow.
Additionally, I renamed "unit" to "units" in a few places, to bring it in line with the BrAPI terminology.
Corresponding PR on bi-api: Breeding-Insight/bi-api#342.
Dependencies
bi-api branch:
bug/BI-2053-fixTesting
In addition to the testing detailed on the bi-api PR, ensure that the form state is preserved as you change selection between Date, Ordinal, Nominal, Numerical and Text types.
Checklist: