Skip to content

BI-2053-fix - Handled Trait Form Submission Code Path#343

Merged
mlm483 merged 2 commits intomainfrom
bug/BI-2053-fix
Apr 26, 2024
Merged

BI-2053-fix - Handled Trait Form Submission Code Path#343
mlm483 merged 2 commits intomainfrom
bug/BI-2053-fix

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Mar 27, 2024

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2053

These changes should have been done along with #331, but I missed the workflow where a user creates ontology terms one at a time by submitting the form on the DeltaBreed GUI. Please see that original PR for rationale.

Corresponding PR on bi-web: #342.

Dependencies

bi-web branch: bug/BI-2053-fix

Testing

Ensure that traits of all types (Date, Ordinal, Nominal, Numerical, Text) can be created via form submission on the DeltaBreed GUI.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@github-actions github-actions bot added the bug Something isn't working label Mar 27, 2024
@mlm483 mlm483 changed the title Bug/bi 2053 fix BI-2053-fix - Handled Trait Form Submission Code Path Mar 27, 2024
@mlm483 mlm483 marked this pull request as ready for review March 27, 2024 23:11
@mlm483 mlm483 requested review from davedrp and dmeidlin March 27, 2024 23:18
Base automatically changed from release/0.9 to main April 10, 2024 21:29
@davedrp
Copy link
Contributor

davedrp commented Apr 12, 2024

Test Plan:

  1. From the Ontology page click on New Term
  2. Enter required fields.
  3. Select numeric for the Scale Class
  4. Enter "in" or any value for Scale Unit.
  5. Click on Save

RESULT BEFORE FIX
An error banner which reads "Error updating ontology term. Missing units;"

EXPECTED RESULT
Success Banner which reads "Trait creation successful."

@davedrp
Copy link
Contributor

davedrp commented Apr 12, 2024

Developer Test passed

@mlm483 mlm483 merged commit ab11e3a into main Apr 26, 2024
@mlm483 mlm483 deleted the bug/BI-2053-fix branch April 26, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants