Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Functioning hh.mod#1237

Merged
1uc merged 17 commits into
masterfrom
jelic/hh_functions
May 10, 2024
Merged

Functioning hh.mod#1237
1uc merged 17 commits into
masterfrom
jelic/hh_functions

Conversation

@JCGoran

@JCGoran JCGoran commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Introduces the necessary changes to get hh.mod to compile and run properly.

TODO:

1uc and others added 5 commits April 8, 2024 13:06
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
@bbpbuildbot

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Apr 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@ada65df). Click here to learn what that means.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 50.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1237   +/-   ##
=========================================
  Coverage          ?   86.36%           
=========================================
  Files             ?      176           
  Lines             ?    13226           
  Branches          ?        0           
=========================================
  Hits              ?    11423           
  Misses            ?     1803           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran marked this pull request as ready for review April 25, 2024 11:08
@JCGoran JCGoran requested review from 1uc and nrnhines April 25, 2024 11:41
@bbpbuildbot

This comment has been minimized.

@JCGoran JCGoran mentioned this pull request May 2, 2024
@JCGoran JCGoran added the NEURON codegen Work toward NEURON code generation label May 2, 2024
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #210303 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've have: #1255 to fix the outstanding issue.

@1uc 1uc merged commit b451d39 into master May 10, 2024
@1uc 1uc deleted the jelic/hh_functions branch May 10, 2024 12:30
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Random collection of fixups to make hh.mod work.

---------

Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>

NMODL Repo SHA: BlueBrain/nmodl@b451d39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NEURON codegen Work toward NEURON code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants