This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Update usecase tests so they compare outputs with NOCMODL#1231
Closed
JCGoran wants to merge 2 commits into
Closed
Conversation
Collaborator
|
This type of diffing has caused considerable pain in the past, in is in many ways the opposite of what I'd like to build. If there's a particular test success when is should fail, then the test should be made more strict. Once we implement enough functionality we'll gain access to ModelDB CI which does these types of checks. |
Collaborator
|
Logfiles from GitLab pipeline #203118 (:white_check_mark:) have been uploaded here! Status and direct links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the testing of usecases as follows:
[arch]/special, we directly call Python, which allows us to actually parse command-line args (is there some downside/side-effect of doing this?)nocmodl.txtornmodl.txt, depending on which one we use for the codegen) with the relevant quantities of interest (voltage as function of time, etc.)run_test.shscript exits with an error codeAll of the above should allow us to catch any differences between NEURON + NOCMODL and NEURON + NMODL (with NEURON codegen) a bit more easily.
Note that the nonspecific current test is not modified until #1218 is merged as the test fails.