This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Test default initialized objects. #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only valid operations of default constructed DataSets and Groups is to assign a valid object to them. Therefore, calling any other methods should raise an exception.
cd455bb to
686229c
Compare
Collaborator
Author
|
@alkino these are changes I'd like to merge into your branch. |
alkino
approved these changes
Apr 2, 2024
1uc
added a commit
that referenced
this pull request
Apr 5, 2024
* Remove deprecated default ctor for DataSet * Allow default ctors. * Test that default constructed objects throw. (#975) The only valid operations of default constructed DataSets and Groups is to assign a valid object to them. Therefore, calling any other methods should raise an exception. --------- Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.