This repository was archived by the owner on Feb 26, 2025. It is now read-only.
Remove deprecated default ctor for DataSet #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
- Coverage 86.13% 86.11% -0.03%
==========================================
Files 90 90
Lines 5858 5847 -11
==========================================
- Hits 5046 5035 -11
Misses 812 812 ☔ View full report in Codecov by Sentry. |
Collaborator
|
This demonstrates that we need to expand the test coverage to ensure it errors out correctly. |
The only valid operations of default constructed DataSets and Groups is to assign a valid object to them. Therefore, calling any other methods should raise an exception.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
+ Coverage 85.45% 86.38% +0.93%
==========================================
Files 92 92
Lines 5787 5898 +111
==========================================
+ Hits 4945 5095 +150
+ Misses 842 803 -39 ☔ View full report in Codecov by Sentry. |
1uc
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.