Skip to content

Include cache options in the add and update verbs of CLI#2655

Merged
aaronburtle merged 16 commits intomainfrom
dev/aaronburtle/AddUpdatCacheEntry
May 6, 2025
Merged

Include cache options in the add and update verbs of CLI#2655
aaronburtle merged 16 commits intomainfrom
dev/aaronburtle/AddUpdatCacheEntry

Conversation

@aaronburtle
Copy link
Contributor

Why make this change?

closes #2603

What is this change?

Includes caching options with the add and update verbs for the CLI. These verbs are used to add or update new entities in a config file, and will now include support for the cache entry in those entities.

How was this tested?

Current test suite.

Sample Request(s)

You can test with the CLI by using the add or update verb along with the flags --cache.enabled and --cache.ttl, default values are false and 5.

Copilot AI review requested due to automatic review settings April 16, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle aaronburtle changed the title Include the Add and Update verbs for Cache Options in the CLI Include cache options in the add and update verbs of CLI Apr 18, 2025
@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@Aniruddh25
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Copy link
Contributor

@RubenCerna2079 RubenCerna2079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronburtle aaronburtle merged commit b578a2c into main May 6, 2025
11 checks passed
@aaronburtle aaronburtle deleted the dev/aaronburtle/AddUpdatCacheEntry branch May 6, 2025 23:04
@Aniruddh25 Aniruddh25 added this to the 1.5 milestone May 11, 2025
RubenCerna2079 added a commit that referenced this pull request May 16, 2025
## Why make this change?

closes #2603

## What is this change?

Includes caching options with the `add` and `update` verbs for the CLI.
These verbs are used to add or update new entities in a config file, and
will now include support for the `cache` entry in those entities.

## How was this tested?

Current test suite.

## Sample Request(s)

You can test with the CLI by using the `add` or `update` verb along with
the flags `--cache.enabled` and `--cache.ttl`, default values are false
and 5.

---------

Co-authored-by: Ruben Cerna <rcernaserna@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
@aaronburtle aaronburtle self-assigned this May 28, 2025
RubenCerna2079 added a commit that referenced this pull request May 29, 2025
## Why make this change?

closes #2603

## What is this change?

Includes caching options with the `add` and `update` verbs for the CLI.
These verbs are used to add or update new entities in a config file, and
will now include support for the `cache` entry in those entities.

## How was this tested?

Current test suite.

## Sample Request(s)

You can test with the CLI by using the `add` or `update` verb along with
the flags `--cache.enabled` and `--cache.ttl`, default values are false
and 5.

---------

Co-authored-by: Ruben Cerna <rcernaserna@microsoft.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
aaronburtle added a commit that referenced this pull request May 29, 2025
## Why make this change?

This change is made in order to add all of the commits for milestone 1.5
into its respective branch.

## What is this change?

This change cherry-picks all of the commits that were added after the
first release candidate.
Cherry-picked commits:
 - #2648 
#2657
#2617 
#2659 
#2655 
#2633 
#2667 
#2673 
#2650 
#2695 
#2702 
#2688

## How was this tested?

- [ ] Integration Tests
- [ ] Unit Tests

## Sample Request(s)

---------

Co-authored-by: Sezal Chug <30494467+sezal98@users.noreply.github.com>
Co-authored-by: sezalchug <sezalchug@microsoft.com>
Co-authored-by: Tommaso Stocchi <tstocchi@microsoft.com>
Co-authored-by: Aaron Powell <me@aaron-powell.com>
Co-authored-by: aaronburtle <93220300+aaronburtle@users.noreply.github.com>
Co-authored-by: Aniruddh Munde <anmunde@microsoft.com>
Co-authored-by: Jerry Nixon <jerry.nixon@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Michael Staib <michael@chillicream.com>
Co-authored-by: souvikghosh04 <souvikofficial04@gmail.com>
Co-authored-by: Souvik Ghosh <sogh@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support cache in the 'add' and 'update' verbs in the CLI

5 participants