[Key Vault] Address administration feedback by mccoyp · Pull Request #19099 · Azure/azure-sdk-for-python

mccoyp · 2021-06-04T03:48:55Z

Summarizing changes:

delete methods return None, do not raise on 404
merge begin_selective_key_restore into begin_restore, former gains a key_name kwarg
begin_restore poller result is None, i.e. no longer a model
remove get_backup_status, get_restore_status
remove models KeyVaultRestoreOperation, KeyVaultSelectiveKeyRestoreOperation
KeyVaultBackupOperation reduced to one property, folder_url
removed prefixes from unambiguous name parameters
- e.g. create_role_assignment(assignment_name=...) -> create_role_assignment(name=...)

Closes #19123

check-enforcer · 2021-06-09T00:35:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

sdk/keyvault/azure-keyvault-administration/CHANGELOG.md

mccoyp · 2021-06-10T19:32:18Z

...yvault/azure-keyvault-administration/azure/keyvault/administration/_access_control_client.py

-        :type role_scope: str or KeyVaultRoleScope
-        :param role_definition_name: the unique role definition name. Unless a UUID is provided, a new role definition
+        :type scope: str or KeyVaultRoleScope
+        :keyword definition_name: the unique role definition name. Unless a UUID is provided, a new role definition


I wonder if we should shorten this to name, since it would align with the UUID name of a role assignment in create_role_assignment, and match the name argument in get_role_definition and delete_role_definition. I initially thought we should keep definition_ to differentiate it from role_name but a plain name in this context sort of implies a definition_ prefix

Seems reasonable to me, let's give it a try.

mccoyp · 2021-06-10T21:30:57Z

sdk/keyvault/azure-keyvault-administration/azure/keyvault/administration/_models.py

-        self._name = kwargs.get("name")
-        self._properties = kwargs.get("properties")
-        self._type = kwargs.get("assignment_type")
+        self.name = kwargs.get("name")


Is there a particular reason to move away from properties?

Architect opinion: https://github.com/Azure/azure-sdk/blob/master/docs/python/_includes/example_client.py#L26

Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

mccoyp

Looks good! I think we need to also override a frozen requirement to get CI passing: https://dev.azure.com/azure-sdk/public/_build/results?buildId=942747&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=b64fce29-1009-5e76-50fb-7b596c2db4c3&l=2026

mccoyp · 2021-06-11T18:24:17Z

sdk/keyvault/azure-keyvault-administration/CHANGELOG.md

+  and `.get_role_assignment`
+- Renamed argument `role_definition_name` to `name` in
+  `KeyVaultAccessControlClient.delete_role_definition` and `.get_role_definition`



We'll want to mention other argument renames too, like role_scope -> scope in multiple methods

…into protocol_base * 'master' of https://github.com/Azure/azure-sdk-for-python: (229 commits) Sync eng/common directory with azure-sdk-tools for PR 1688 (#19272) update all ubuntu vmImage to 20.04 (#19227) add base class for feedback (#19265) Enable tests for integration samples (#18531) docs: fix a few simple typos (#19127) Increment package version after release of azure-eventgrid (#19197) Increment package version after release of azure-monitor-query (#19208) earliest versions of communication identity tests are set up improperly. skip 1.0.0 in regression testing (#19258) Run mypy in azure-keyvault-administration CI (#19246) [text analytics] change return type of analyze actions to list of list (#18994) Increment package version after release of azure-data-tables (#19192) suppress min number less than 14 (#19230) [Key Vault] Address administration feedback (#19099) [textanalytics] remove warning tests (#19217) [translation] enable samples to run in CI (#19190) update custom_granularity_value to be more than 300 (#19215) Increment package version after release of azure-security-attestation (#19212) Enabling Before/After Test Customization for Standard CI Pipelines (#19187) bump sphinx version to resolve the weird issue with the caption not getting the correct class (#19188) [AutoRelease] t2-agrifood-2021-06-09-15946 (#19174) ...

role_definition_name as kwarg

60a72ef

mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 4, 2021

mccoyp added 2 commits June 4, 2021 12:43

Return None on delete

7442201

Remove role_ param prefixes

ec3bc3f

mccoyp mentioned this pull request Jun 7, 2021

[Key Vault] Revise administration models #19049

Closed

chlowell added 8 commits June 7, 2021 11:30

delete methods don't raise on 404

af9331e

remove prefix from unambiguous name parameters

eb0383c

merge begin_selective_key_restore into begin_restore

e6650a6

update tests

61f5af1

keep only KeyVaultBackupOperation.folder_url

2e26acc

remove get_*_status methods

d18b9d4

update tests

a41fcc6

update changelog

3a75e4e

mccoyp mentioned this pull request Jun 9, 2021

Revise administration models #13575

Closed

4 tasks

chlowell added 7 commits June 9, 2021 09:09

remove unused imports

8b5cdfa

enums are interchangeable with case-insensitive strings

38b5c41

clear challenge cache between tests

66cf889

update recordings

5c368d2

remove model properties

34b9551

need at least azure-core 1.11.0

06d0967

don't claim to support 3.5

1d8cfd1

chlowell marked this pull request as ready for review June 10, 2021 17:41

chlowell requested review from chlowell and schaabs as code owners June 10, 2021 17:41

mccoyp commented Jun 10, 2021

View reviewed changes

chlowell and others added 3 commits June 10, 2021 15:48

Update sdk/keyvault/azure-keyvault-administration/CHANGELOG.md

a48553f

Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

definition_name -> name

78bdc9e

update readme

a3dab4f

mccoyp commented Jun 11, 2021

View reviewed changes

chlowell added 3 commits June 11, 2021 12:29

update shared_requirements

4115cdd

more changelog

d1f6c63

protect pylint from six.with_metaclass

ad1334f

chlowell approved these changes Jun 11, 2021

View reviewed changes

mccoyp merged commit c52fa66 into Azure:master Jun 12, 2021

mccoyp deleted the roledefname branch June 12, 2021 01:16

mccoyp mentioned this pull request Jun 16, 2021

Successful restore operations may yield error #18992

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Key Vault] Address administration feedback#19099

[Key Vault] Address administration feedback#19099
mccoyp merged 24 commits intoAzure:masterfrom
mccoyp:roledefname

mccoyp commented Jun 4, 2021 •

edited by chlowell

Loading

Uh oh!

check-enforcer bot commented Jun 9, 2021

Uh oh!

Uh oh!

mccoyp Jun 10, 2021

Uh oh!

chlowell Jun 11, 2021

Uh oh!

mccoyp Jun 10, 2021

Uh oh!

chlowell Jun 10, 2021

Uh oh!

mccoyp left a comment

Uh oh!

mccoyp Jun 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mccoyp commented Jun 4, 2021 • edited by chlowell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

check-enforcer bot commented Jun 9, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

Uh oh!

mccoyp Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

chlowell Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

mccoyp Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

chlowell Jun 10, 2021

Choose a reason for hiding this comment

Uh oh!

mccoyp left a comment

Choose a reason for hiding this comment

Uh oh!

mccoyp Jun 11, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mccoyp commented Jun 4, 2021 •

edited by chlowell

Loading