-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Resolve architects' review feedback for Key Vault #19123
Copy link
Copy link
Closed
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.KeyVault
Milestone
Description
Feedback from our architects:
- Delete methods on the
KeyVaultAccessControlClientshould return None and ignore HTTP 404s. - KeyVaultRestoreOperation and KeyVaultSelectiveKeyRestoreOperation can be removed
-
KeyVaultBackupClient.begin_restoreand.begin_selective_key_restorecan be merged into a single method -- akey_namekwarg will determine the behavior - KeyVaultBackupOperation should only have a
folder_urlproperty - Restore operations should return
LROPoller[None], and backup operations should returnLROPoller[KeyVaultBackupOperation] - Instead of
get_backup_statusandget_restore_status, pollers should be rehydrate-able with a simplified continuation token (e.g. the value of the response'sazure-asyncoperationheader instead of a pickled PipelineResponse) -
role_*parameter names should be shortened as much as possible without ambiguity
Feel free to update this issue with idiomatic feedback.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.KeyVault