Skip to content

DNS Proxy in Firewall Policy#12120

Merged
VeryEarly merged 3 commits intoAzure:network-mayfrom
ishaniGupta27:dnsInPolicy2
Jun 12, 2020
Merged

DNS Proxy in Firewall Policy#12120
VeryEarly merged 3 commits intoAzure:network-mayfrom
ishaniGupta27:dnsInPolicy2

Conversation

@ishaniGupta27
Copy link
Copy Markdown
Contributor

@ishaniGupta27 ishaniGupta27 commented Jun 11, 2020

Description

We are extending the usability of DNS Settings to Azure Firewall Manager - Policy. DNS Settings allows customers to add custom servers to policy which will be attached to firewall. Also, the firewall will allow having destinationfqdns in network rules for policy.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/611
- [ ] the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Copy Markdown
Collaborator

adxsdkps commented Jun 11, 2020

Can one of the admins verify this patch?

@ishaniGupta27 ishaniGupta27 changed the title Dns in policy2 DNS Proxy in Firewall Policy Jun 11, 2020
@VeryEarly VeryEarly self-assigned this Jun 11, 2020
VeryEarly
VeryEarly requested changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and use singular for cmdlet/parameter names, and update help mardowns

anton-evseev
anton-evseev approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@anton-evseev anton-evseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI errors

Ishani Gupta added 2 commits June 11, 2020 10:30
@VeryEarly VeryEarly merged commit f7b324f into Azure:network-may Jun 12, 2020
VeryEarly added a commit that referenced this pull request Jun 16, 2020
@anton-evseev @aegal
@Nilambari @saisujithreddym @tejasshah7 @Khushboo-Baheti @ishaniGupta27 @VeryEarly @jaishals @nagula-ritvika
Network May release (#12157)
4697bbe 
* PR: LoadBalancerBackendAddressPool powershell Cmdlets (#11734)

* lb backend address pool create/update/delete operations

* adding tests with draft

* making some updates for design review PR to powershell team

* adding .md files

* -adding tests
-updating help files
-addressing feedback

* pulling in sdk changes for network-may branch for validation errors

* Addressing comments and updating output format for PsLoadBalancerBackendAddress

* updating .md files and making final changes

Co-authored-by: Ali Egal <alegal@microsoft.com>

* Adding new optional parameter to specify dns servers for Virtual Wan P2SVpnGateway and P2SClients (#12006)

* Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients

* Incorporate code review comments and added test record

* Suppress warnings

* Suppress cred scan errors

* updating help files examples (#12068)

Co-authored-by: Ali Egal <alegal@microsoft.com>

* multipip changes

* Do not pass new fields with default values unless configured explicitly (#12076)

* multi pip changes

* ps tests

* generating help files

* help files changes

* help file

* regenerating help files

* updated markdown file

* renaming the cmdlets

* name change

* tests

* renaming a help file

* updating the recordings

* test

* Used signed Network SDK with API version 2020-05-01 (#12100)

* Network SDK for 2020-05-01

* Fixes for FirewallPolicy

* Recs

* Recs

* SDK package

* Ignore Network API version in Batch tests

* CredScan suppression

* clean up

* updatid recordings

* clean up

* clean up

* Vpn gateway commandlet update (#12108)

* commit1

* commit2

* Fix1

Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

* addressing comments

* added exceptions

* correcting the exceptions

* Change RuleGroup, RuleCollectionGroup, and RuleType and add support for Multiple DNAT Rule Collections (#12095)

* Change RuleGroup and RuleCollectionGroup based on swagger change. Also,
add support for NAT Rule Collections containing multiple NAT Rule
Collections

* PR Comments

* Updated the SDK

* StaticAnalysis

* Previous changes got removed in rebase

* update to vnet reference id only

* Use Network SDK from NuGet (#12114)

* Use Network SDK from NuGet

* Additional mappings

* Firewall Policy ThreatIntelWhitelist (#12078)

* ti whitelist changes

* build fix

* help files

* added examples for help files

* adding the online version

* recordings done

* changed to markdown files

* fixed statis analysis

* added exception for static analysis

* addressing comments

* updated recordings

* new recordings

* updating due to validation error on CICD pipeline

* refreshing test files, updating to remove id from variable to fix casting error

* DNS Proxy in Firewall Policy (#12120)

* merge conflict

* fixes

* tejas review

Co-authored-by: Ishani Gupta <isgu@microsoft.com>

* Add support for IPGroups in Firewall Policy Rules (#12118)

* Add support for IPGroups in Firewall Policy Rules

* Pr Comments

* Resolved merge conflicts

* Update ChangeLog.md

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Application Gateway Private Link Cmdlets (#12133)

* Application Gateway Private Link Cmdlets

* add change log

* Add new cmdlet Reset-AzHubRouter (#12094)

* add routing state and expose reset-hubrouter

* update help

* updated

* Update ChangeLog.md

* update help file name

* export cmdlet

* update test

* fix

* update md file

* update tests

* updated help

* Update Reset-AzHubRouter.md

* test recorded

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* Fixes after merge

* Revert HPCCache.Test.csproj

Co-authored-by: aegal <aegal@outlook.com>
Co-authored-by: Ali Egal <alegal@microsoft.com>
Co-authored-by: Nilambari <nilamd@microsoft.com>
Co-authored-by: Sai Mankala <samankal@microsoft.com>
Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com>
Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>
Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com>
Co-authored-by: Ishani Gupta <isgu@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Co-authored-by: jaishals <jaishal.shah@gmail.com>
Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

+2 more reviewers

@tejasshah7 tejasshah7 tejasshah7 left review comments

@anton-evseev anton-evseev anton-evseev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VeryEarly VeryEarly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ishaniGupta27 @adxsdkps @anton-evseev @VeryEarly @tejasshah7