PR: LoadBalancerBackendAddressPool powershell Cmdlets by aegal · Pull Request #11734 · Azure/azure-powershell

aegal · 2020-04-28T17:43:51Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

adxsdkps · 2020-04-28T17:43:54Z

Can one of the admins verify this patch?

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs

ninzavivek · 2020-04-28T22:38:46Z

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs

+
+        [JsonProperty(Order = 1)]
+        public string IpAddress { get; set; }
+


do we need to check the combination, as we dicussed?

No I don't think so, right now we don't populate NIC config if provided, so PsLoadBalancerBackendAddress will always have a IpAddress and VNET ID, other wise an error is returned by New-AzLoadBalancerBackendAddressConfig which creates this object.

the fact that we cannot modify does not mean that we can see it as read only

it is read only if available now.

src/Network/Network/LoadBalancer/SetAzureLoadBalancerBackendPool.cs

src/Network/Network/LoadBalancer/NewAzLoadBalancerBackendAddressConfig.cs

ninzavivek · 2020-04-28T22:46:33Z

src/Network/Network/Common/NetworkResourceManagerProfile.cs

+                // CNM to MNM
+                cfg.CreateMap<CNM.PSNetworkInterfaceIPConfiguration, MNM.NetworkInterfaceIPConfiguration>();
+
+                // LoadBalancerBackendAddress


move above nic?

I should actually remove NetworkInterfaceIPConfiguration conversion here as we are not allowing that in this change.

also when we do we'll do on the load balancer backend address, not on this networkInterfaces inside the backend pool

src/Network/Network/Az.Network.psd1

src/Network/Network/LoadBalancer/RemoveAzureLoadBalancerBackendPool.cs

-updating help files -addressing feedback

anton-evseev

Please address validation failures

anton-evseev · 2020-05-18T16:07:11Z

src/Accounts/Accounts/AzureRmAlias/Mappings.json

    "Set-AzVirtualNetworkGatewayConnectionSharedKey": "Set-AzureRmVirtualNetworkGatewayConnectionSharedKey",
    "Set-AzVirtualNetworkGatewayConnection": "Set-AzureRmVirtualNetworkGatewayConnection",
    "New-AzIpsecPolicy": "New-AzureRmIpsecPolicy",
+    "Get-AzLoadBalancerBackendAddressPool": "Get-AzureRmLoadBalancerBackendAddressPool",


No need to add mappings AFAIK

It doesnt harm if I add it anyways? Wanna make sure I don't miss anything.

AFAIK AzureRm aliases aren't supported for new cmdlets as an incentive for users to move to Az
@VeryEarly could you please clarify?

src/Network/Network/Common/NetworkResourceManagerProfile.cs

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs

ninzavivek

Are the included nupkg needed as part of PR?

src/Network/Network/Az.Network.psd1

gmainar · 2020-05-19T00:50:35Z

src/Network/Network/Common/NetworkResourceManagerProfile.cs

+                // CNM to MNM
+                cfg.CreateMap<CNM.PSNetworkInterfaceIPConfiguration, MNM.NetworkInterfaceIPConfiguration>();
+
+                // LoadBalancerBackendAddress


also when we do we'll do on the load balancer backend address, not on this networkInterfaces inside the backend pool

src/Network/Network/Common/NetworkResourceManagerProfile.cs

gmainar · 2020-05-19T01:01:03Z

src/Accounts/Accounts/AzureRmAlias/Mappings.json

    "Set-AzVirtualNetworkGatewayConnectionSharedKey": "Set-AzureRmVirtualNetworkGatewayConnectionSharedKey",
    "Set-AzVirtualNetworkGatewayConnection": "Set-AzureRmVirtualNetworkGatewayConnection",
    "New-AzIpsecPolicy": "New-AzureRmIpsecPolicy",
+    "Get-AzLoadBalancerBackendAddressPool": "Get-AzureRmLoadBalancerBackendAddressPool",


src/Network/Network/LoadBalancer/GetAzureLoadBalancerBackendPool.cs

src/Network/Network/LoadBalancer/SetAzureLoadBalancerBackendPool.cs

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs

gmainar · 2020-05-19T01:47:25Z

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs

+
+        [JsonProperty(Order = 1)]
+        public string IpAddress { get; set; }
+


the fact that we cannot modify does not mean that we can see it as read only

src/Network/Network.Test/ScenarioTests/LoadBalancerBackendPoolTests.ps1

src/Network/Network/LoadBalancer/NewAzureLoadBalancerBackendPool.cs

…endAddress

src/Network/Network/LoadBalancer/GetAzureLoadBalancerBackendPool.cs

src/Network/Network/LoadBalancer/NewAzureLoadBalancerBackendPool.cs

src/Network/Network/LoadBalancer/RemoveAzureLoadBalancerBackendPool.cs

src/Network/Network/help/New-AzLoadBalancerBackendAddressConfig.md

src/Network/Network/help/Set-AzLoadBalancerBackendAddressPool.md

src/Network/Network/help/Remove-AzLoadBalancerBackendAddressPool.md

src/Network/Network/LoadBalancer/SetAzureLoadBalancerBackendPool.cs

aegal · 2020-05-29T01:26:09Z

Adding @isra-fel to this, please take a look if you get a chance.

VeryEarly · 2020-05-29T06:35:36Z

Hi @aegal ,

Please add examples for "New-AzLoadBalancerBackendAddressPool.md"
There are test cases need to be re-recorded due to SDK upgrade

src/HPCCache/HPCCache.Test/HPCCache.Test.csproj

Changes accomodated

* lb backend address pool create/update/delete operations * adding tests with draft * making some updates for design review PR to powershell team * adding .md files * -adding tests -updating help files -addressing feedback * pulling in sdk changes for network-may branch for validation errors * Addressing comments and updating output format for PsLoadBalancerBackendAddress * updating .md files and making final changes Co-authored-by: Ali Egal <alegal@microsoft.com>

* PR: LoadBalancerBackendAddressPool powershell Cmdlets (#11734) * lb backend address pool create/update/delete operations * adding tests with draft * making some updates for design review PR to powershell team * adding .md files * -adding tests -updating help files -addressing feedback * pulling in sdk changes for network-may branch for validation errors * Addressing comments and updating output format for PsLoadBalancerBackendAddress * updating .md files and making final changes Co-authored-by: Ali Egal <alegal@microsoft.com> * Adding new optional parameter to specify dns servers for Virtual Wan P2SVpnGateway and P2SClients (#12006) * Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients * Incorporate code review comments and added test record * Suppress warnings * Suppress cred scan errors * updating help files examples (#12068) Co-authored-by: Ali Egal <alegal@microsoft.com> * multipip changes * Do not pass new fields with default values unless configured explicitly (#12076) * multi pip changes * ps tests * generating help files * help files changes * help file * regenerating help files * updated markdown file * renaming the cmdlets * name change * tests * renaming a help file * updating the recordings * test * Used signed Network SDK with API version 2020-05-01 (#12100) * Network SDK for 2020-05-01 * Fixes for FirewallPolicy * Recs * Recs * SDK package * Ignore Network API version in Batch tests * CredScan suppression * clean up * updatid recordings * clean up * clean up * Vpn gateway commandlet update (#12108) * commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> * addressing comments * added exceptions * correcting the exceptions * Change RuleGroup, RuleCollectionGroup, and RuleType and add support for Multiple DNAT Rule Collections (#12095) * Change RuleGroup and RuleCollectionGroup based on swagger change. Also, add support for NAT Rule Collections containing multiple NAT Rule Collections * PR Comments * Updated the SDK * StaticAnalysis * Previous changes got removed in rebase * update to vnet reference id only * Use Network SDK from NuGet (#12114) * Use Network SDK from NuGet * Additional mappings * Firewall Policy ThreatIntelWhitelist (#12078) * ti whitelist changes * build fix * help files * added examples for help files * adding the online version * recordings done * changed to markdown files * fixed statis analysis * added exception for static analysis * addressing comments * updated recordings * new recordings * updating due to validation error on CICD pipeline * refreshing test files, updating to remove id from variable to fix casting error * DNS Proxy in Firewall Policy (#12120) * merge conflict * fixes * tejas review Co-authored-by: Ishani Gupta <isgu@microsoft.com> * Add support for IPGroups in Firewall Policy Rules (#12118) * Add support for IPGroups in Firewall Policy Rules * Pr Comments * Resolved merge conflicts * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Yabo Hu <yabhu@microsoft.com> * Application Gateway Private Link Cmdlets (#12133) * Application Gateway Private Link Cmdlets * add change log * Add new cmdlet Reset-AzHubRouter (#12094) * add routing state and expose reset-hubrouter * update help * updated * Update ChangeLog.md * update help file name * export cmdlet * update test * fix * update md file * update tests * updated help * Update Reset-AzHubRouter.md * test recorded Co-authored-by: Yabo Hu <yabhu@microsoft.com> * Fixes after merge * Revert HPCCache.Test.csproj Co-authored-by: aegal <aegal@outlook.com> Co-authored-by: Ali Egal <alegal@microsoft.com> Co-authored-by: Nilambari <nilamd@microsoft.com> Co-authored-by: Sai Mankala <samankal@microsoft.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com> Co-authored-by: Khushboo Baheti <37917868+Khushboo-Baheti@users.noreply.github.com> Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com> Co-authored-by: Ishani Gupta <ishani.gupta27.ig@gmail.com> Co-authored-by: Ishani Gupta <isgu@microsoft.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com> Co-authored-by: jaishals <jaishal.shah@gmail.com> Co-authored-by: Ritvika Reddy Nagula <rinagula@microsoft.com>

aegal added 2 commits April 23, 2020 16:37

lb backend address pool create/update/delete operations

ecc2744

adding tests with draft

58b8437

aegal requested a review from ninzavivek April 28, 2020 17:43

ninzavivek suggested changes Apr 28, 2020

View reviewed changes

aegal requested review from anton-evseev and gmainar April 28, 2020 23:15

aegal added 2 commits May 4, 2020 11:25

making some updates for design review PR to powershell team

3714ca9

adding .md files

9fa0322

aegal changed the base branch from master to Az.Network-preview May 4, 2020 20:21

aegal changed the base branch from Az.Network-preview to master May 4, 2020 20:56

-adding tests

390d7a9

-updating help files -addressing feedback

aegal changed the base branch from master to network-may May 18, 2020 02:48

aegal changed the base branch from network-may to master May 18, 2020 02:49

aegal changed the base branch from master to network-may May 18, 2020 02:50

aegal changed the title ~~DRAFT PR: LoadBalancerBackendAddressPool powershell Cmdlets~~ PR: LoadBalancerBackendAddressPool powershell Cmdlets May 18, 2020

anton-evseev previously requested changes May 18, 2020

View reviewed changes

aegal marked this pull request as ready for review May 18, 2020 23:36

aegal commented May 19, 2020

View reviewed changes

src/Network/Network/Common/NetworkResourceManagerProfile.cs Outdated Show resolved Hide resolved

aegal commented May 19, 2020

View reviewed changes

src/Network/Network/Models/PSLoadBalancerBackendAddress.cs Outdated Show resolved Hide resolved

ninzavivek reviewed May 19, 2020

View reviewed changes

aegal commented May 19, 2020

View reviewed changes

src/Network/Network/Az.Network.psd1 Outdated Show resolved Hide resolved

gmainar reviewed May 19, 2020

View reviewed changes

aegal added 3 commits May 19, 2020 09:29

merging network-may into backendpoolchange2 branch

920355e

pulling in sdk changes for network-may branch for validation errors

681f52b

Addressing comments and updating output format for PsLoadBalancerBack…

9a24d14

…endAddress

aegal requested review from anton-evseev, gmainar and ninzavivek May 21, 2020 18:48

VeryEarly self-assigned this May 25, 2020

ninzavivek suggested changes May 27, 2020

View reviewed changes

aegal requested a review from isra-fel May 29, 2020 01:25

updating .md files and making final changes

7a93667

aegal requested a review from ninzavivek May 29, 2020 15:49

ninzavivek reviewed May 29, 2020

View reviewed changes

src/HPCCache/HPCCache.Test/HPCCache.Test.csproj Show resolved Hide resolved

ninzavivek approved these changes May 29, 2020

View reviewed changes

aegal merged commit 2b76cb9 into network-may May 30, 2020

wyunchi-ms deleted the backendPoolChanges2 branch January 10, 2024 02:02


		[JsonProperty(Order = 1)]
		public string IpAddress { get; set; }

Conversation

aegal commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

adxsdkps commented Apr 28, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anton-evseev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ninzavivek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aegal commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VeryEarly commented May 29, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

aegal commented Apr 28, 2020 •

edited

Loading

aegal commented May 29, 2020 •

edited

Loading