Provide a reconcile command to try and bring clusters back to desired…#4719
Provide a reconcile command to try and bring clusters back to desired…#4719paulgmiller wants to merge 15 commits intoAzure:mainfrom
Conversation
|
@FumingZhang I didn't use the decorator pattern becauase this reconcile command should never grow or change and when we put it in non - preview we should be able to reuse the exact same function like show. This repalces #4083 |
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
Yeah, I like the idea to use a separate command to do the "empty" PUT request. Left some suggestions to pass the custom header.
|
And from CI log, need to add help message for the new commands. |
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
|
@FumingZhang I pushed some help but style and linter in azdev locally give me alot of failure snot relatedto my change. Is that expected? |
|
Why not |
I'm not sure update is better #4759 |
|
Moving this to #4759 |
… state
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.