allow user to do empty az aks update to reconcile cluster#4083
Closed
paulgmiller wants to merge 1 commit intoAzure:mainfrom
Closed
allow user to do empty az aks update to reconcile cluster#4083paulgmiller wants to merge 1 commit intoAzure:mainfrom
paulgmiller wants to merge 1 commit intoAzure:mainfrom
Conversation
xhl873
reviewed
Nov 8, 2021
| if prompt_y_n("no arguments specicied would you like to reconcile?", default="n"): | ||
| #duplicating this worse than goto? | ||
| headers = get_aks_custom_headers(aks_custom_headers) | ||
| return sdk_no_wait(no_wait, client.create_or_update, resource_group_name, name, instance, custom_headers=headers) |
Contributor
There was a problem hiding this comment.
the instance here should be the datat model after Get, so it may be slightly different than am empty put? IMO, it should behave the same as empty put since nothing is changed, but not sure if there will be surprise or not :P
Collaborator
|
aks |
FumingZhang
reviewed
Nov 10, 2021
| if prompt_y_n("no arguments specicied would you like to reconcile?", default="n"): | ||
| #duplicating this worse than goto? | ||
| headers = get_aks_custom_headers(aks_custom_headers) | ||
| return sdk_no_wait(no_wait, client.create_or_update, resource_group_name, name, instance, custom_headers=headers) |
Member
There was a problem hiding this comment.
It seems that the change is made on a really really old code base, I suppose you need to update it to resolve some conflicts. Besides the function signature of create_or_update has changed since we adopted the track 2 SDK, thus you need to change the name of the argument custom_headers to headers.
Author
|
replacing with speraet az aks reconcile command |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.