Aks [nodepool] update without args prompts to reconcile. #4759
Aks [nodepool] update without args prompts to reconcile. #4759zhoxing-ms merged 13 commits intoAzure:mainfrom
Conversation
|
AKS |
| '"--disable-cluster-autoscaler" or ' | ||
| '"--update-cluster-autoscaler" or ' | ||
| '"--tags" or "--mode" or "--max-surge" or "--scale-down-mode" or "--labels" or "--node-taints') | ||
| reconcilePrompt = "no argument specified to update would you like to reconcile to current settings?" |
There was a problem hiding this comment.
minor: Use ' rather than " for consistency, since from what I can tell that's the style used elsewhere in this file.
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
|
@FumingZhang I think we're good on the aks side so looking for your review at this point. |
|
In addition, the CI failure is due to a test case that is not related to this PR. Will fix it in another PR. |
|
Do you need to add a new version for this extension to release these changes? If so, please also modify the |
I'm not sure what the pattern is here do we bump the version on every change or batch several of them? Bumped version and HISTORY.md but not actually what is normal here.
Is there a way to rerun tests? |
@paulgmiller It mainly depends on whether you want these features to be released immediately in a new extension version? |
This is an alternateive to #4719 aks is debating.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.