Use implicit dependency instead of depends_on#622
Merged
magodo merged 5 commits intoAzure:mainfrom May 12, 2025
Merged
Conversation
magodo
reviewed
May 8, 2025
magodo
reviewed
May 9, 2025
Member
Author
|
e2e test passes: |
magodo
approved these changes
May 12, 2025
magodo
added a commit
that referenced
this pull request
Jun 13, 2025
* Reapply "Convert explict dependency (via `depends_on`) to implicit dependency (via reference) when there is a ID reference (#622)" (#628) This reverts commit 130e84a. * Replace transitive dependencies with TF address * Big refactor of dependency handling logic * PR review cycle 2 - Refactor config_info model, avoid redundant types - Shorten variable names - Avoid strong string types * Minor changes * Add parentChildDep even if already exist as ambiguousRefDep --------- Co-authored-by: magodo <wztwcy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved export logic such that when resourceId-valued attribute is matched against a dependency resource, use implicit TF address instead of depends_on syntax.
Config exported in previous behaviour:
Config exported in the new behaviour:
If no such value is found, it will still fall-back to depends_on.
The replacement is done in recursive manner. Values nested in children blocks will also be replaced.