Improved dependency application in exported HCL#625
Merged
magodo merged 6 commits intoAzure:mainfrom Jun 13, 2025
Merged
Conversation
ba69efd to
c38ceca
Compare
- Refactor config_info model, avoid redundant types - Shorten variable names - Avoid strong string types
magodo
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves dependency application in the exported HCL by refactoring the deduplication logic and respecting transitive dependency when selecting implicit / depends_on strategy.
Given the below dependency graph:
The exported HCL of A will have a
depends_onto the resource group as per current behaviour, but B now only have implicitazurerm_a_resource.res-1.idTF address reference. The logic now understands that the transitive dependency to the Res. group is implied.