Add search to the Professional plan warm welcome#8945
Conversation
There was a problem hiding this comment.
Looks pretty good to me.
I got this brief error when clicking the link:
Quickly disappears because of the page load. I am guessing this is either because I have that one line commented out, or because I already had search enabled.
Request URL:[removed]/index.php?rest_route=/jetpack/v4/settings
Request Method:POST
Status Code:400 Bad Request
I also seem to get this when I just try to close the dialog.
Other than this, I would approve the PR. Can you reproduce?
|
Hmm, yeah, I can reproduce and I'm not sure what's up. 🤔 |
|
I couldn't reproduce that warning message when starting from scratch and acquiring a Pro Plan |
zinigor
left a comment
There was a problem hiding this comment.
I can reproduce the problem by running this code on a site that has Extra Sidebar Widgets disabled, so it's a manifestation of #9041. And the error seems to be happening because the settings endpoint can not find the respective setting.
Should we first enable Extra Sidebar Widgets here?
Also, it may be a red herring, but it looks like the request gets cancelled because of the page load, I can't even debug it in the dev toolbar.
gibrown
left a comment
There was a problem hiding this comment.
I think that since the bug I raised is covered by that other issue (which has another PR to fix it) that we should merge this as is.
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Fixes #8694.
Changes proposed in this Pull Request:
#8694 (comment)
Testing instructions:
returnto get the dialog to show up: https://github.com/Automattic/jetpack/blob/master/_inc/client/components/welcome-new-plan/index.jsx#L50yarn buildto build a fresh set of the JavaScript app.wp-adminon a site that has the Professional plan. Check out the updated dialog box.Changelog entry
Added Search to the features listed on the Warm Welcome dialog for Professional Plan