Add new Social Icons widget and deprecate old Social Media Icons widget#8498
Merged
Add new Social Icons widget and deprecate old Social Media Icons widget#8498
Conversation
…et. Closes #7454 Closing previous PR/branch and opening a new one due to an issue with a rebase.
zinigor
previously requested changes
Jan 29, 2018
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Found one minor problem.
| } | ||
|
|
||
| // [DEPRECATION]: Only register widget if active widget exists already | ||
| if ( 1 === $has_widget ) { |
Contributor
There was a problem hiding this comment.
I think there's some weird type handling going on - I was only able to get deprecated widgets shown on my site after I removed the strict type check from this if, and made it if( $has_widget) . Maybe get_transient or set_transient do something funny here?
Anyway, seems to be working with this one nitpick.
…get if active widget exists already
dereksmart
requested changes
Feb 20, 2018
Contributor
dereksmart
left a comment
There was a problem hiding this comment.
@thomasguillot If the New Tab checkbox isn't checked, a notice is thrown on the front end with debug on.
( ! ) Notice: Undefined variable: new_tab in /home/dereksma/public_html/wp-content/plugins/jetpack/modules/widgets/social-icons.php on line 137
Contributor
|
Will fix #7601 as well |
Will set the target attribute to `_blank` or `_self` depending on the new tab option being ticked or not.
Contributor
Author
|
Hey @dereksmart, thanks for your review. The PHP error should now be fixed. |
dereksmart
approved these changes
Mar 13, 2018
Contributor
|
LGTM! |
zinigor
added a commit
that referenced
this pull request
Mar 27, 2018
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
jeherve
added a commit
that referenced
this pull request
Mar 30, 2018
oskosk
pushed a commit
that referenced
this pull request
Mar 30, 2018
oskosk
pushed a commit
that referenced
this pull request
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3776
Fixes #7433
Fixes #7601
Closing previous PR/branch (#7454) and opening a new one due to an issue with a rebase.
To keep in line with WPCOM, I’d like to add the new Social Icons
widget. You can add this widget to any site and you should have a new
widget as seen on its documentation page
(https://en.support.wordpress.com/widgets/social-media-icons-widget/).
The old widget should become unavailable to sites not using it. If they
do then we add a “(Deprecated)” to the label.
In
social-icons.php, L72, we use the samesocial-menu.svgfile asthe one used for the Social Menu.