[WIP] Add Jetpack CSS support for Code Editor control in core patch#7794
Closed
westonruter wants to merge 1 commit into
Closed
[WIP] Add Jetpack CSS support for Code Editor control in core patch#7794westonruter wants to merge 1 commit into
westonruter wants to merge 1 commit into
Conversation
Contributor
Author
|
The dependency https://github.com/xwp/wordpress-develop/pull/257 has been merged into |
Contributor
|
Closing in favour of #8028. (The commit here is included in the other PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to give you a jump start on updating Custom CSS in Jetpack with the new code editor APIs in 4.9-alpha. This is just an initial integration which fixes the JS error that was caused by Jetpack and core conflicting. I'm sure there is additional integration work needed, specifically in the realm of switching between CSS, LESS, and SCSS. But I hope this is helpful for you to get started and also to evaluate the proposed core changes in Trac #41897 which makes the Custom CSS control in the Customizer actually extensible (please apply that core patch or checkout the branch to test). Any findings from the Jetpack integration here will inform what changes need to be made in that core patch.
So I hand this over to the Jetpack team to amend as needed.
Depends on https://github.com/xwp/wordpress-develop/pull/257 which resolves https://core.trac.wordpress.org/ticket/41897
Fixes #7776.